GitHub synchronization not working and pull requests are not synchronized due to NoSuchMethodError

This is due to an incorrect build of the 2.1 jar file.

Impacts

This affects 6.3-OD1 (released on 31 Mar 2014).

It affects GitHub synchronization where there's at least one PR.

Cause

It is causing the wrong egit PullRequest class to be loaded into the jar in the original 2.1 jar file uploaded to maven.atlassian.com.

The DVCS Connector has its own copy of egit PullRequest class but it's not properly included in the original 2.1 jar file.

In original 2.1 jar file:

2014-03-12 13:16:08 .....         7489         2140  org/eclipse/egit/github/core/PullRequest.class

In the 2.1.3 jar file (with the correct PullRequest class):

2012-12-03 17:10:00 .....         7276         2062  org/eclipse/egit/github/core/PullRequest.class

This affected the 6.3 OD1 release, with the following errors when synchronizing GitHub requests:

@40000000533ca2100c23c3e4 2014-04-03 10:49:26,200 pool-15-thread-1 ERROR nmason 649x480x1 esyrp 59.167.133.1,59.167.29.201 /rest/bitbucket/1.0/repository/12/fullsync [dvcs.service.message.MessageConsumer] org.eclipse.egit.github.core.PullRequest.getReviewComments()I
@40000000533ca2100c23d384 java.lang.NoSuchMethodError: org.eclipse.egit.github.core.PullRequest.getReviewComments()I
@40000000533ca2100c23d76c at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.updateCommentsCount(GitHubPullRequestSynchronizeMessageConsumer.java:292)
@40000000533ca2100c241204 at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.processPullRequestComments(GitHubPullRequestSynchronizeMessageConsumer.java:242)
@40000000533ca2100c2415ec at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.onReceive(GitHubPullRequestSynchronizeMessageConsumer.java:109)
@40000000533ca2100c241dbc at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.onReceive(GitHubPullRequestSynchronizeMessageConsumer.java:40)
@40000000533ca2100c2421a4 at com.atlassian.jira.plugins.dvcs.service.MessageExecutor$MessageRunnable.run(MessageExecutor.java:273)
@40000000533ca2100c243144 at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
@40000000533ca2100c24352c at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
@40000000533ca2100c24352c at java.lang.Thread.run(Thread.java:662)
@40000000533ca2100d074614 Exception in thread "pool-15-thread-1" java.lang.NoSuchMethodError: org.eclipse.egit.github.core.PullRequest.getReviewComments()I
@40000000533ca2100d07c314 at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.updateCommentsCount(GitHubPullRequestSynchronizeMessageConsumer.java:292)
@40000000533ca2100d07f1f4 at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.processPullRequestComments(GitHubPullRequestSynchronizeMessageConsumer.java:242)
@40000000533ca2100d08539c at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.onReceive(GitHubPullRequestSynchronizeMessageConsumer.java:109)
@40000000533ca2100d08633c at com.atlassian.jira.plugins.dvcs.sync.GitHubPullRequestSynchronizeMessageConsumer.onReceive(GitHubPullRequestSynchronizeMessageConsumer.java:40)
@40000000533ca2100d08b15c at com.atlassian.jira.plugins.dvcs.service.MessageExecutor$MessageRunnable.run(MessageExecutor.java:273)
@40000000533ca2100d08e80c at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
@40000000533ca2100d095d3c at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
@40000000533ca2100d096124 at java.lang.Thread.run(Thread.java:662)

We could not rebuild and redeploy a good version due to https://ecosystem.atlassian.net/browse/AMPS-1112