Disabling JQL diagnostics monitor dark feature requires Jira restart to take effect

XMLWordPrintable

    • 10.03
    • 2
    • Severity 3 - Minor
    • 41

      Issue Summary

      Disabling the default-on JQL diagnostics monitor through com.atlassian.diagnostics.jql.monitor.disabled does not take effect immediately.

      Steps to Reproduce

      1. Start Jira with the JQL diagnostics monitor enabled
      2. Trigger a slow JQL query so JiraMonitorConfiguration caches the monitor as enabled
      3. Enable the site dark feature com.atlassian.diagnostics.jql.monitor.disabled
      4. Trigger another slow JQL query without restarting Jira

      Expected Results

      The JQL diagnostics monitor is disabled immediately and no new JQL diagnostics alert is persisted.

      Actual Results

      The JQL diagnostics monitor remains enabled until its cache is reset, e.g. after Jira is restarted.

      JiraMonitorConfiguration only resets its cached feature state when it receives an event for the base feature key:

      com.atlassian.diagnostics.jql.monitor
      

      It ignores the event raised when this default-on feature is disabled through:

      com.atlassian.diagnostics.jql.monitor.disabled
      

      Workaround

      Enable both dark features in this order:

      1. com.atlassian.diagnostics.jql.monitor.disabled
      2. com.atlassian.diagnostics.jql.monitor

      The first disables the monitor. The second does not re-enable it because the .disabled key takes precedence, but it raises an event for the base feature key and resets the cached monitor state.

      A rolling restart also applies the disabled flag on each node.

              Assignee:
              Daniel Rauf
              Reporter:
              Daniel Rauf
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: