[Documentation] `pool-min-size` and `pool-min-idle` are the same

XMLWordPrintable

    • Type: Bug
    • Resolution: Unresolved
    • Priority: Low
    • None
    • Affects Version/s: 8.0.0, 8.20.0, 9.0.0, 10.0.0
    • Component/s: Documentation - All
    • None
    • 8
    • Severity 3 - Minor

      Problem Definition

      • In the previous request we made a distinction between `pool-min-size` and `pool-min-idle` in the documentation:

        The minimum size and idle are merged where the same doesn't happen to the maximum counterpart, and that causes confuse to the customer regarding what to set for those two values.

      That is however not true and checking the code we can confirm there's no JDBC configuration for `pool-min-idle`:

      • jira-components/jira-core/src/main/java/com/atlassian/jira/config/database/JdbcDatasource.java
                // Basic connection pool properties
                final ConnectionPoolInfo poolInfo = ConnectionPoolInfo.builder()
                        // Normal settings...
                        .setPoolMaxSize(poolMaxSize)
                        .setPoolMinSize(parseInteger(datasourceElement, POOL_MIN_SIZE))
                        .setPoolMaxWait(parseLong(datasourceElement, POOL_MAX_WAIT))
                        .setPoolSleepTime(parseLong(datasourceElement, POOL_SLEEP_TIME))
                        .setPoolLifeTime(parseLong(datasourceElement, POOL_LIFE_TIME))
                        .setDeadLockMaxWait(parseLong(datasourceElement, DEADLOCK_MAX_WAIT))
                        .setDeadLockRetryWait(parseLong(datasourceElement, DEADLOCK_RETRY_WAIT))
                        .setValidationQuery(datasourceElement.elementText(VALIDATION_QUERY))
                        .setMinEvictableTimeMillis(parseLong(datasourceElement, MIN_EVICTABLE_IDLE_TIME_MILLIS))
                        .setTimeBetweenEvictionRunsMillis(parseLong(datasourceElement, TIME_BETWEEN_EVICTION_RUNS_MILLIS))
                        // Advanced settings...
                        .setDefaultCatalog(datasourceElement.elementText(DEFAULT_CATALOG))
                        .setMaxOpenPreparedStatements(parseInteger(datasourceElement, MAX_OPEN_PREPARED_STATEMENTS))
                        .setNumTestsPerEvictionRun(parseInteger(datasourceElement, POOL_NUM_TESTS_PER_EVICTION_RUN))
                        .setPoolInitialSize(parseInteger(datasourceElement, POOL_INITIAL_SIZE))
                        .setPoolMaxIdle(parseInteger(datasourceElement, POOL_MAX_IDLE))
                        .setPoolPreparedStatements(parseBoolean(datasourceElement, POOL_PREPARED_STATEMENTS))
                        .setRemoveAbandonedOnBorrow(parseBoolean(datasourceElement, POOL_REMOVE_ABANDONED_ON_BORROW))
                        .setRemoveAbandonedOnMaintenance(parseBoolean(datasourceElement, POOL_REMOVE_ABANDONED_ON_MAINTENANCE))
                        .setRemoveAbandonedTimeout(parseInteger(datasourceElement, POOL_REMOVE_ABANDONED_TIMEOUT))
                        .setTestOnBorrow(parseBoolean(datasourceElement, POOL_TEST_ON_BORROW))
                        .setTestOnReturn(parseBoolean(datasourceElement, POOL_TEST_ON_RETURN))
                        .setTestWhileIdle(parseBoolean(datasourceElement, POOL_TEST_WHILE_IDLE))
                        .setValidationQueryTimeout(parseInteger(datasourceElement, VALIDATION_QUERY_TIMEOUT))
                        .build();
        

      Suggested Solution

      Remove the Minimum Idle section and add it in parenthesis below the `pool-min-size`.

      Minimum Idle/Size pool-min-size Value of Maximum Size The minimum number of idle database connections that can be open at any time.
      Why are the default values of Minimum Size and Maximum Size the same?
       
       
      Minimum Idle poolmin-idle- Value of Minimum Size The minimum number of database connections that are allowed to remain idle in the pool

      Workaround

      None

            Assignee:
            Tomasz Prus (Inactive)
            Reporter:
            Mateus Gomes (Inactive)
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: