Issue Summary

On "Find an issue" page, the role link is defined inappropriately for "Details" and "Add this filter from your Favorite Filters / Remove this filter from your Favorite Filters" buttons.

Note : Similar issue is found on "Edit Current Filter" page for "Remove this filter from your Favorite Filters" button (appears on activating detail button then activating "Edit permissions" link).

Steps to Reproduce

1. Open above page.
2. Save any filter. 
3. Navigate through mentioned buttons using screen reader or inspect the code. 
4. Observe that the buttons are inappropriately defined as links. 

Screenshot

Actual Results

The "Details" and "Add this filter from your Favorite Filters / Remove this filter from your Favorite Filters" buttons are defined using <a> element. This conveys incorrect functionality to screen reader users. This might confuse screen reader users.

Expected Results

Make sure that the interactive elements have correct role. Markup "Details" and "Add this filter from your Favorite Filters / Remove this filter from your Favorite Filters" interactive elements using <button> semantics. 

Additionally, add aria-expanded="" attribute on "Details" button. Make sure that the value of aria-expanded="" attribute changes on interaction. 

<button aria-expanded="true" ...>Details</button>

Workaround

Not available

Environment

MacBook Pro (16-inch, 2021)

macOS Sonoma Version 14.1

Chrome - Version 119.0.6045.159 (Official Build) (arm64)

Firefox- Version 93.0 (32-bit) Safari- Version 17.1 (19616.2.9.11.7)

JAWS- Version 2023

NVDA- Version 2020.3

Voiceover - Version Latest