Issue Summary

The aria-haspopup="dialog" attribute is not defined for "Feedback" button which triggers a modal dialog.

Steps to Reproduce

1. Navigate to the header section.
2. Using screen reader, navigate onto the "Feedback" button and activate it.
3. Observe the dialog gets added on the page, but the button did not indicate that it will trigger a dialog.
4. Inspect the code and observe that required aria attribute is missing.

Screenshot

Actual Results

When screen reader users navigate onto the "Feedback" button, it does not indicate user of a modal dialog. The required aria attribute i.e, aria-haspopup="dialog" is missing on the button element.

Not defining the aria-haspopup="dialog" attribute for a pop-up element can result in a poor user experience for screen reader users, as users relying on assistive technologies may not be aware of the presence of a dialog.

Expected Results

To resolve this issue, modify the aria-attribute of the "Feedback" button to aria-haspopup="dialog". This attribute indicates that a pop-up dialog can be triggered by interacting with the element.

Code Snippet

<a class="jira-feedback-plugin" role="button" aria-label="Feedback" aria-haspopup="dialog" id="jira-header-feedback-link" href="#">
    <span class="aui-icon aui-icon-small aui-iconfont-feedback">Give feedback to Atlassian</span>
</a>

Workaround

Currently there is no known workaround for this behavior. A workaround will be added here when available

Environment

MacBook Pro (16-inch, 2021)
macOS: Sonoma 14.3
Chrome - Version 119.0.6045.105 (Official Build) (64-bit)
Firefox- Version 92.0 (64-bit)
Safari- Version 16.6 (18615.3.12.11.2)
JAWS- Version 2023
NVDA- Version 2021.2
Voiceover - Version Latest