Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-7433

Make Header Banner dynamic (rather than static in the jira-application.properties)

XMLWordPrintable

    • We collect Jira feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      I have writen an action/page to do this - I am attaching the code / changed files here.

        1. actions.xml
          114 kB
        2. admin.jsp
          14 kB
        3. AnnouncementHeaderHolder.java
          0.6 kB
        4. bodytop.jsp
          10 kB
        5. editannouncement.jsp
          1 kB
        6. EditAnnouncementHeader.java
          0.7 kB

            [JRASERVER-7433] Make Header Banner dynamic (rather than static in the jira-application.properties)

            AntonA added a comment -

            Hiding the banner is tracked by JRA-8544

            AntonA added a comment - Hiding the banner is tracked by JRA-8544

            Nick Minutello added a comment -

            would be trivial to hide it if jira isnt public mode & user not logged in

            Out of curiosity, what sensitive information would you put there?

            Nick Minutello added a comment - would be trivial to hide it if jira isnt public mode & user not logged in Out of curiosity, what sensitive information would you put there?

            Kevin Wilson added a comment -

            The announcement shows before a user is logged in, not good if you need to post sensitive info on a private installation that is accessible from the internet.

            Kevin Wilson added a comment - The announcement shows before a user is logged in, not good if you need to post sensitive info on a private installation that is accessible from the internet.

            Jeff Turner added a comment -

            Many thanks - a modified version of this has been added for 3.4.

            Jeff Turner added a comment - Many thanks - a modified version of this has been added for 3.4.

            Nick Minutello added a comment -

            C'mon guys, push this in

            Nick Minutello added a comment - C'mon guys, push this in

            Nick Minutello added a comment -

            In fact, in the bodytop.jsp, you might want to do something more like this - so that it still loads the value from jira-application.properties

            AnnouncementHeaderHolder holder = AnnouncementHeaderHolder.getInstance();
            String alertHeader = holder.getAnnouncement() != null ? holder.getAnnouncement() : headerAP.getDefaultBackedString(APKeys.JIRA_ALERT_HEADER);

            Nick Minutello added a comment - In fact, in the bodytop.jsp, you might want to do something more like this - so that it still loads the value from jira-application.properties AnnouncementHeaderHolder holder = AnnouncementHeaderHolder.getInstance(); String alertHeader = holder.getAnnouncement() != null ? holder.getAnnouncement() : headerAP.getDefaultBackedString(APKeys.JIRA_ALERT_HEADER);

              Unassigned Unassigned
              3b1ae0ec93c9 Nick Minutello
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: