Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-38484

commented.vm contains uncommented text, is included in html notifications

    XMLWordPrintable

Details

    Description

      There seems to be some text left in the following resource which is feeding into outgoing emails (its the only template present with this):

      jira-project/jira-components/jira-core/src/main/resources/templates/email/html/includes/fields/comment.vm

      It was reported in 6.2.1 and is still present in 6.3m04?

      full text
      #disable_html_escaping()
      
      !! TODO: make use of text-top and comment-top patterns !!      <---------------- this should be prefixed.....
      #if ($comment)
          <table class="notification-comment-pattern" cellspacing="0" cellpadding="0" border="0" width="100%">
              <tr>
                  <td class="notification-comment-pattern-container mobile-resize-text">
                      This pattern is obsolete! Use comment-top instead.
      
                      $htmlComment
                      ## TODO: visibility
                      <div style="color:$textSubtleColour;padding:4px 0 0 0;">#visibilityHtml()</div>
                  </td>
              </tr>
          </table>
      #end
      

      This causes a problem when rendered, as the !! line is not prefixed with a valid velocity comment string, the entire line gets injected into the comment header of html notifications.

      Attachments

        Issue Links

          Activity

            People

              ohernandez@atlassian.com Oswaldo Hernandez (Inactive)
              340ad212567f Andy Brook [Plugin People]
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: