Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-36859

Top level navigation links may contain duplicated item id's

    XMLWordPrintable

Details

    • 6
    • Severity 2 - Major
    • Hide
      Atlassian Update – 28 May 2018

      Hi everyone,

      We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Time Out.

      Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details.

      We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication.
      Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

      Thank you,
      Ignat Alexeyenko
      Jira Bugmaster

      Show
      Atlassian Update – 28 May 2018 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Time Out . Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Thank you, Ignat Alexeyenko Jira Bugmaster

    Description

      The current implementation of the MainHeaderLinksContextProvider class allows to have two items with exactly the same ID.

      Steps to reproduce

      1. Install the eazyBI plugin
      2. Install the Pathfinder plugin

      The top-level nav should contain two new positions - each of them will have the same id="home"

      Impact

      If they are just buttons in the topnav - nothing except duplicated ids in HTML. But if they were drop-downs then they would be clashing with each other showing inappropriate content for those drop-downs.

      Suggested Solution

      The technical solution also disallow to create drop-down items with non-unique ids.

      There are few possible solutions. The best one would be namespacing those IDs with plugin's key.

      There are possible dependencies on those id's (which eventually are printed out to HTML) that would need fixing. For example, Plugin vendors (and JIRA Core) may use those IDs to bind javascript actions and styling.

      Consequently, fixing this only seems to be viable in a breaking release (7.0 for instance)

      Attachments

        Activity

          People

            Unassigned Unassigned
            mnowakowski Maciej Nowakowski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: