Details
-
Bug
-
Resolution: Timed out
-
Medium
-
6.0, 6.1
-
6
-
Severity 2 - Major
-
-
Description
The current implementation of the MainHeaderLinksContextProvider class allows to have two items with exactly the same ID.
Steps to reproduce
- Install the eazyBI plugin
- Install the Pathfinder plugin
The top-level nav should contain two new positions - each of them will have the same id="home"
Impact
If they are just buttons in the topnav - nothing except duplicated ids in HTML. But if they were drop-downs then they would be clashing with each other showing inappropriate content for those drop-downs.
Suggested Solution
The technical solution also disallow to create drop-down items with non-unique ids.
There are few possible solutions. The best one would be namespacing those IDs with plugin's key.
There are possible dependencies on those id's (which eventually are printed out to HTML) that would need fixing. For example, Plugin vendors (and JIRA Core) may use those IDs to bind javascript actions and styling.
Consequently, fixing this only seems to be viable in a breaking release (7.0 for instance)