-
Bug
-
Resolution: Fixed
-
High (View bug fix roadmap)
-
5.0, 5.0.1, 5.0.2
-
None
-
5
-
When I start @-mentioning people in JIRA, it's incredibly difficult to discern whether anything is actually happening or not. If the server takes several seconds to return a result, you have little to no idea that the feature is even active until you're rather bored of waiting.
- incorporates
-
-
- Closed
-
- is duplicated by
-
-
- Closed
-
- is related to
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
-
- Closed
-
[JRASERVER-27998] Mentions can fail to show results
Well done Daz and big thanks to Dave E for QA. This is my last comment on JAC where I avoided mentions 
I've re-QAd this on a real IE8/9 machine and I'm satisfied that the issues raised above are fixed. This certainly marks a big improvement in the scalability and usability of Mentions and my hat goes off to cdarroch for all of his hard work on this issue!
pwyatt, I've committed fixes for the issues you mentioned to 5.1.1 and master. It's ready for another bout of punishment
Two issues so far, related:
Issue 1:
1) Type @username where "username" matches only one person.
2) Defocus the window.
3) Click back in the text field.
4) Press enter and keep typing. The suggestions popup doesn't go away.
Issue 2:
1) Type @garbage where "garbage" matches no users.
2) Defocus the window.
3) Click back in the text field.
4) Press enter and keep typing. A Javascript error is thrown - "$suggestions is undefined"
Doesn't reproduce in dev mode.
The way Mentions is built is that it uses an InlineLayer class, which in turn retrieves its data from an AJAXContentRetriever. The way those two classes interop with each-other is such that the InlineLayer's contents are only ever updated (thus shown or not) when the AJAXContentRetriever receives a response from the server. The way this happens is through an incredibly convoluted and confusing chain of function calls internal to those two classes.
Splitting the concern of updating the UI from retrieving data from the source seems near-impossible without rewriting significant parts of these two classes.
Good luck to whoever tries to separate these concerns.
JRA-27898 speaks to the slowness on JAC and mentions the unresponsiveness of the UI. This issue details the UI problems.
The '@' performance can be quite abysmal most of the time.
It also gets incredibly confused as to whether it should search or not; if I alter the text near or around the '@' symbol, then move the caret, requests will still get fired.
A lot.
Awesome - can't wait until this hits JAC!