-
Type:
Suggestion
-
Resolution: Fixed
-
Component/s: Infrastructure & Services - Application Lifecycle
-
None
In the various text files in JIRA (*.jsp, *.vm, *.css etc), some files end with a newline, some don't. This wouldn't matter in the slightest, except that:
- Some editors (vim, gedit, but not IDEA, Eclipse, emacs) will automatically add a newline when saving a file. Wikipedia says "The general convention on most systems is to add a newline even after the last line, i.e., to treat newline as a line terminator."
- 'diff' expects each line to end with a newline character, and generates a spurious diff block if it doesn't find it:
/tmp/atlassian-jira-enterprise-3.12.1-standalone/atlassian-jira$ diff logout.jsp.orig logout.jsp 11a12 > test modification 33c34 < </html> \ No newline at end of file --- > </html>
In the interests of making JIRA patchers' lives a bit easier, we should standardize on newlines at the end of text files.