-
Suggestion
-
Resolution: Unresolved
-
None
-
3
-
In the current setup of the Issue card, located under the development section, there exists a MERGE button designed to facilitate the quick merging of an issue on BitBucket into its target branch. However, this feature lacks any form of checks or balances, which poses a significant risk. Users can inadvertently click this button, resulting in an unintended merge.
Merging should be a deliberate action that undergoes thorough review. The presence of a one-click-to-merge option is problematic, as it increases the likelihood of accidental merges. At a minimum, a confirmation window should appear, allowing users to verify their intention before proceeding with the merge.
Ideally, the MERGE button should be removed entirely from the JIRA card. Merging from this control accelerates the workflow unnecessarily and undermines the review process, which should be prioritized. Removing this feature would help prevent bypassing critical review steps.
Additionally, delays in the card's loading time can contribute to accidental clicks, as the MERGE button may appear where a user's cursor is positioned when the card finally opens. This further emphasizes the need for a more robust safeguard against unintentional actions.
[JRACLOUD-93484] Merge button on issue view panel should either have an option to be disabled or enabled and show a confirmation panel when clicked
Recording my comments from the thread where this was originally discussed :
I am a developer, and it is the opposite of useful; it caused me a MAJOR headache today by breaking our builds and causing me to interrupt planned work to go fix what Jira screwed up.
It might be useful, if it was implemented with sensibility, but some mind-boggling decisions were made here:
- It merges all PRs associated with the issue - even ones that are not yet approved!
- There is not even a confirmation for such a drastic action
This is easily the worst, most regressive capability I've seen added to Jira in the 10+ years we've been using it.
It has now happened twice in two days, causing havoc and upheaval both times. We are also a ISO27001 certified organization, and this change jeopardizes our good standing with ISO. I just (accidentally) merged 2 PRs without them being approved; how is that going to look when the auditor requests to see our chain of authority on these tickets?!?
I humbly request that this feature be removed immediately, and put behind some sort of feature flag. I hate to sound alarmist, but the consequences here are so bad that if this persists without any reasonable workaround, we will be forced to look for Jira alternatives (something we do not want to do, to be clear).
I agree with the Reporter and Igor that addition of a merge shortcut button is incredibly dangerous. Not only are there no checks, but the prompt does not show the PR, so anyone who presses merge, is doing so blindly. How do they know whether the PR was properly reviewed, all outstanding tasks are resolved / review comments addressed.
This change severely undermines the review process by hiding it away.
This change should be rolled back as a matter of urgency.
Thanks to 93d691d77e10 for creating the issue from my request. It was a surprise to be sure when I accidentally merged a PR that hadn't been reviewed yet. Thankfully it was a minor PR so I wasn't too concerned (and we weren't on the threshold of a release!). Will be much more careful when opening Jira cards now...
I vote for this to be removed entirely, this also happened to my team where we accidentally merged a fairly big PR and it caused a lot of stress. Big thumbs down!
This can cause significant pain when accidentally clicked in Jira. This happened with my team, fortunately on a relatively simple PR. However, to resolve this and put it back into a PR still wasted 0.5hr and we were lucky that this didn't automatically trigger CI/CD for that specific project.
I'd like to mention it happened again. The button shifts everything down in the Card when it appears, about 2-3 seconds after opening the card. The most egregious part is that it appears over the link to the PR. So, I was going to click on the PR link to review it, when instead I merged it.
It begs the question: do these features get tested?