Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-21854

Temporary images created by jfreechart are not cleaned up

XMLWordPrintable

      None of our JIRA instances are cleaning up the temporary images created by jfreechart. The tomcat/temp directory of jira.atlassian.com had 350,000 files, for example.

      The files look like:

      -rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11646 Jul 25 14:17 jfreechart-onetime-949352571854230169.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11952 Jul 25 12:39 jfreechart-onetime-957538706595968267.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11757 Jul 25 04:01 jfreechart-onetime-963208896751366693.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11674 Jul 25 16:13 jfreechart-onetime-969684489244123410.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11646 Jul 25 14:41 jfreechart-onetime-971540390290389047.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com   9370 Jul 24 23:57 jfreechart-onetime-974789924774468593.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com   9321 Jul 25 01:05 jfreechart-onetime-977625683314475437.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com   8245 Jul 25 01:50 jfreechart-onetime-985842978856772519.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com   9321 Jul 25 00:07 jfreechart-onetime-986348626327708513.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11674 Jul 25 18:31 jfreechart-onetime-988462419623200103.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11674 Jul 25 18:19 jfreechart-onetime-993845373684162071.png
-rw-r--r--  1 j2ee_jira.atlassian.com j2ee_jira.atlassian.com  11779 Jul 25 10:31 jfreechart-onetime-999941953045481311.png

      This is a major problem as it's quite possible that a highly utilised server (like JAC or SAC) can die due to lack of disk space.

        1. Selection_059.png
          Selection_059.png
          34 kB

            [JRASERVER-21854] Temporary images created by jfreechart are not cleaned up

            Trevor Campbell (Inactive) added a comment -

            Any performance impact should be in a good way, we remove a write to disk as well as a read (I/O is a big issue in OD) and remove a browser<-->server round trip.

            Trevor Campbell (Inactive) added a comment - Any performance impact should be in a good way, we remove a write to disk as well as a read (I/O is a big issue in OD) and remove a browser<-->server round trip.

            Trevor Campbell (Inactive) added a comment - - edited

            While there are many reasons the image may not be retrieved and therefore left lying around forever, in my testing it seems there is one major culprit which might be simply addressed.

            When a second application requests a gadget from JIRA, e.g. A JIRA gadget on a Confluence page or even another JIRA's dashboard, the gadget makes two requests for the chart, but naturally enough only displays the one (second) image. The first image is never displayed or deleted. So if you have a chart from another JIRA updating on a wallboard each 5 minutes, then you will add one of these every 5 minutes.

            I have uploaded screenshot, of the network traffic from firebug showing a

            • GET to makeRequest followed by a
            • PUT to makeRequest
              Both generate and return information for a chart, but only the second shart is actually requested.

            You can also see from the traffic, the requests go to my localhost, but the image is being sourced from a different running JIRA application.

            The behaviour is slightly different depending upon the application link configuration and if you are authorised on the end target machine, but the effective result is the same - 2 chart requests.

            Trevor Campbell (Inactive) added a comment - - edited While there are many reasons the image may not be retrieved and therefore left lying around forever, in my testing it seems there is one major culprit which might be simply addressed. When a second application requests a gadget from JIRA, e.g. A JIRA gadget on a Confluence page or even another JIRA's dashboard, the gadget makes two requests for the chart, but naturally enough only displays the one (second) image. The first image is never displayed or deleted. So if you have a chart from another JIRA updating on a wallboard each 5 minutes, then you will add one of these every 5 minutes. I have uploaded screenshot, of the network traffic from firebug showing a GET to makeRequest followed by a PUT to makeRequest Both generate and return information for a chart, but only the second shart is actually requested. You can also see from the traffic, the requests go to my localhost, but the image is being sourced from a different running JIRA application. The behaviour is slightly different depending upon the application link configuration and if you are authorised on the end target machine, but the effective result is the same - 2 chart requests.

            Oswaldo Hernandez (Inactive) added a comment -

            Hi matt.doar, unfortunately no, the regression was fixed by reverting this fix, so this fix will have to be changed so that it doesn't cause the regression at JRA-34911

            Regards,

            Oswaldo Hernández.
            JIRA Bugmaster.
            [Atlassian].

            Oswaldo Hernandez (Inactive) added a comment - Hi matt.doar , unfortunately no, the regression was fixed by reverting this fix, so this fix will have to be changed so that it doesn't cause the regression at JRA-34911 Regards, Oswaldo Hernández. JIRA Bugmaster. [Atlassian] .

            MattS added a comment -

            Oswaldo, the regression is marked as Fixed so can the fix for this be used now?

            MattS added a comment - Oswaldo, the regression is marked as Fixed so can the fix for this be used now?

            Oswaldo Hernandez (Inactive) added a comment - - edited

            Hi kjell.lauren@ericsson.com,

            Unfortunately, the initial fix to this issue cause an important regression, which was tracked at JRA-34911, so we had to roll-back the fix.

            At the moment this bug is not in our backlog and has not been scheduled for any upcoming JIRA maintenance as we are currently working through higher priority issues in other areas of JIRA. Having said that, it is still a bug we would like to fix, please watch this issue as I will update it when more information is available.

            Regards,

            Oswaldo Hernández.
            JIRA Bugmaster.
            [Atlassian].

            Oswaldo Hernandez (Inactive) added a comment - - edited Hi kjell.lauren@ericsson.com , Unfortunately, the initial fix to this issue cause an important regression, which was tracked at JRA-34911 , so we had to roll-back the fix. At the moment this bug is not in our backlog and has not been scheduled for any upcoming JIRA maintenance as we are currently working through higher priority issues in other areas of JIRA. Having said that, it is still a bug we would like to fix, please watch this issue as I will update it when more information is available. Regards, Oswaldo Hernández. JIRA Bugmaster. [Atlassian] .

            Kjell Lauren added a comment -

            The bug still exists in Jira 6.1.5, any news on when it will be fixed?

            Kjell Lauren added a comment - The bug still exists in Jira 6.1.5, any news on when it will be fixed?

            Luis Miranda (Inactive) added a comment -

            ifurmanov this will be fixed in JIRA 6.1.1 (see JRA-34911). Downgrading is unfortunately not supported.

            Luis Miranda (Inactive) added a comment - ifurmanov this will be fixed in JIRA 6.1.1 (see JRA-34911 ). Downgrading is unfortunately not supported.

            Ilya Furmanov added a comment -

            Thanks!
            Apparently I don't have enough permissions to view issue you mentioned.
            Should I expect fix from Confluence or from JIRA side?
            I just checked jira 6.1 and issue is reproduced there.
            Is it possible to downgrade from jira 6.0.8 to jira 6.0.7?

            Ilya Furmanov added a comment - Thanks! Apparently I don't have enough permissions to view issue you mentioned. Should I expect fix from Confluence or from JIRA side? I just checked jira 6.1 and issue is reproduced there. Is it possible to downgrade from jira 6.0.8 to jira 6.0.7?

            Luis Miranda (Inactive) added a comment -

            Yes, see linked issue CONFDEV-19885.

            Luis Miranda (Inactive) added a comment - Yes, see linked issue CONFDEV-19885.

            Ilya Furmanov added a comment - - edited

            Luis, could those side effect include inability to display jira gadgets in confluence?

            Ilya Furmanov added a comment - - edited Luis, could those side effect include inability to display jira gadgets in confluence?

              ohernandez@atlassian.com Oswaldo Hernandez (Inactive)
              pkorathota Pramod Korathota (Inactive)
              Affected customers:
              18 This affects my team
              Watchers:
              29 Start watching this issue

                Created:
                Updated:
                Resolved: