Uploaded image for project: 'HipChat'
  1. HipChat
  2. HCPUB-73

Browsing to HipChat Server returns Invalid Request when cookie contains a special character

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Low
    • None
    • HCS 1.3.5, HCS 1.3.4, HCS 1.3.7
    • Login, Website
    • Severity 3 - Minor

    Description

      Summary

      When accessing HipChat Server in a web browser with a cookie containing certain special characters, an invalid request error occurs.

      Steps to Reproduce

      This can be reproduced with a 'curl' to the HipChat Server:

      curl 'https://example.hipchatserver.com/home' -H 'Cookie: C%40=023' --compressed
      Invalid Request
      
      curl 'https://example.hipchatserver.com/home' -H 'Cookie: C=023' --compressed
      <h1>302 - Found</h1><p><a href="https://examle.hipchatserver.com/sign_in?d=%2Fhome">https://example.hipchatserver.com/sign_in?d=%2Fhome</a></p>

      This can be reproduced against https://example.hipchatserver.com/, as well.

      Expected Results

      Request will succeed and users are able to successfully access HipChat Server in a web browser.

      Actual Results

      An 'Invalid Request' error is returned in the web browser.

      Workaround

      1. back up the HipChat Server as a precaution
      2. log into the HipChat Server terminal/command-line interface
      3. run the following commands to download the patch, make it executable, and run it:
        wget https://s3.amazonaws.com/hipchat-server-stable/utils/clean-cookie-patch.sh
        chmod +x clean-cookie-patch.sh
        sudo dont-blame-hipchat -e "./clean-cookie-patch.sh"

      Attachments

        Issue Links

          Activity

            People

              dbredensteiner Derek Bredensteiner (Inactive)
              scovey Shanye
              Archiver:
              mandreacchio Michael Andreacchio

              Dates

                Created:
                Updated:
                Resolved:
                Archived: