DATA LINK ESCAPE character in attachment file name breaks room load for the desktop clients

Summary

If file with the DATA LINK ESCAPE character in its name is uploaded as attachment, the room history load will break.

Environment

• All desktop clients
• Hipchat Server 2.2.9
• Hipchat Data Center 3.1.3

Steps to Reproduce

1. Create a file in a Linux system with the character in its name

   touch Test$(echo -e '\u0010')File
   

2. Upload the file to a room in Hipchat
3. Close the room and re-open it

Expected Results

1. Room history should load and file should be visible.

Actual Results

• Room history doesn't load
• The below error is thrown in the tetra.err.log file:

  2018-03-02T09:32:00.420823+00:00 adridi-haproxy tetra-proxy-1: [] ERROR: Invalid XML data received on [ClusterProxyProtocol:app:adridi-223.lightning.hcsinf.com:5368]: '<cluster><jids><jid> ...
  

Notes

• Upon file upload, the file is not immediately visible in the client UI
• There might be other characters causing this error

Workaround

• Review the latest Redis history of the room for a file with an unusual Unicode encoded character

  redis-cli LRANGE history:room:1_<room_name_from_db> 0 -1 | jq .
  

• Ask the user who uploaded the file to delete through the web UI