Provide the ability to configure the maximum number of reviews requested.

XMLWordPrintable

    • Type: Suggestion
    • Resolution: Unresolved
    • None
    • Component/s: User interface
    • None

      Requesting more than 500 reviews may have a negative impact on the performance and memory usage of Crucible. Please provide a setting where the maximum number of reviews retrieved can be configured.

      At the moment, the Byteman script below is used, but it does not handle the endpoint /cru/reviewagereportimg

      #
# com.cenqua.crucible.model.managers.impl.DefaultReviewManager
# getMatchingReviewIds(com.cenqua.crucible.view.reviewfilters.ReviewFilterDef, java.lang.String, com.cenqua.crucible.util.ReviewSort)
#
RULE DefaultReviewManager_getMatchingReviewIds_limit_query
CLASS com.cenqua.crucible.model.managers.impl.DefaultReviewManager
METHOD getMatchingReviewIds(com.cenqua.crucible.view.reviewfilters.ReviewFilterDef, java.lang.String, com.cenqua.crucible.util.ReviewSort)
AT EXIT
BIND
    reviewLimit : int = 500;
IF $!.size() > reviewLimit
DO
    org.slf4j.LoggerFactory.getLogger("Byteman")
            .info("Query found {} review ids. Returning only {} of them.",
                    new Object[] { $!.size(), reviewLimit } );

    return $!.subList(0, reviewLimit);

ENDRULE

            Assignee:
            Unassigned
            Reporter:
            Andrew Bimba (Inactive)
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: