Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-7489

Provide the ability to configure the maximum number of reviews requested.

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • None
    • User interface
    • None

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      Requesting more than 500 reviews may have a negative impact on the performance and memory usage of Crucible. Please provide a setting where the maximum number of reviews retrieved can be configured.

      At the moment, the Byteman script below is used, but it does not handle the endpoint /cru/reviewagereportimg

      #
# com.cenqua.crucible.model.managers.impl.DefaultReviewManager
# getMatchingReviewIds(com.cenqua.crucible.view.reviewfilters.ReviewFilterDef, java.lang.String, com.cenqua.crucible.util.ReviewSort)
#
RULE DefaultReviewManager_getMatchingReviewIds_limit_query
CLASS com.cenqua.crucible.model.managers.impl.DefaultReviewManager
METHOD getMatchingReviewIds(com.cenqua.crucible.view.reviewfilters.ReviewFilterDef, java.lang.String, com.cenqua.crucible.util.ReviewSort)
AT EXIT
BIND
    reviewLimit : int = 500;
IF $!.size() > reviewLimit
DO
    org.slf4j.LoggerFactory.getLogger("Byteman")
            .info("Query found {} review ids. Returning only {} of them.",
                    new Object[] { $!.size(), reviewLimit } );

    return $!.subList(0, reviewLimit);

ENDRULE

      Attachments

        Activity

          People

            Unassigned Unassigned
            abimba@atlassian.com Andrew Bimba
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: