Cannot download binary file if name contains special characters

Fisheye provides ability to download binary files from repository. Download link is corrupted if file name contains special letters.

Steps to reproduce:

1. Add binary file with the special letters in name (e.g. file with (strange) #chars.exe) to the repository
2. Add repository to the Fisheye
3. Open file page in the Fisheye
4. Click on Download revision <revision hash> link

Expected result:

• file starts to downloading

Actual result:

• error page appears:
  

Cause

Fisheye does not replace html char codes properly, so it tries to find file with name file%20with%20%28strange%29%20%23chars.exe instead of file with (strange) #chars.exe.

Problem occurs if path to file from the repository root contains non-standard chars.

Workaround

Expected url can be created manually. Each occurrence of  %25 should be changed to %. 

Example

Fisheye generates link to the file:

•  <url>/file%2520with%2520%2528strange%2529%2520%2523chars.exe

Valid url should look like:

• <url>/file%20with%20%28strange%29%20%23chars.exe