Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-6359

FishEye displays an incorrect committer for a user with an underscore in its username

    XMLWordPrintable

Details

    • Bug
    • Resolution: Answered
    • Low
    • N/A
    • 3.10.2, 3.10.3, 4.0.0
    • None

    Description

      Summary

      The committer information is not displayed correctly when accessing a changeset in case the user contains an underscore in its username.

      Steps to Reproduce

      The steps below have been tested with a Git repository, but they may apply to other repository types.

      1. Create a user in FishEye with yut as Username, Yut as Display name and yut@fisheye.com as Email
      2. Create a user in FishEye with y_t as Username, Y_t as Display name and y_t@fisheye.com as Email
      3. These are the users in FishEye after the steps above
      4. In a Git repository, set the Git configuration option for user.name and user.email to match the user with the underscore so that the Git config -l command returns:
        • git config -l
          user.name=Y_t
          user.email=y_t@fisheye.com
          
      5. Commit and push to the Git repository. The Git log command returns Y_t as Author:
        • git log <commit_hash>
          commit ae59dba0943811fdbcbd76ab0f2e1938e87b9c1d
          Author: Y_t <y_t@fisheye.com>
          Date:   Tue Feb 9 11:30:17 2016 +1100
          
      6. Locate the commit in FishEye

      Expected Results

      The Y_t display name, matching the y_t user, is displayed as committer.

      Actual Results

      The Yut display name, matching the yut user, is displayed as committer.

      When clicking on the user displayed, the page containing the details of the yut user (without the underscore) is loaded (note the <FishEye url>/user/yut in the title bar), and the page shows the "This user has not yet committed." message:

      Notes

      The user creation sequence (yut - user without the underscore before y_t - user with the underscore) is critical. If the users are created in the reversed sequence, then the problem does not occur.

      Workaround

      Delete the user shown instead of the expected one, yut in this example, and recreate it.
      The correct username is displayed after the user yut is deleted, and recreated:

      Attachments

        1. FE6359_YutUser.png
          FE6359_YutUser.png
          27 kB
        2. FE6359_users.png
          FE6359_users.png
          16 kB
        3. FE6359_repositoryActivity.png
          FE6359_repositoryActivity.png
          16 kB
        4. FE6359_correctRepositoryActivity.png
          FE6359_correctRepositoryActivity.png
          16 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ccurti Caterina Curti
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: