Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-5334

Smart Commits: command without comment while creating a review including a reviewer not working

    XMLWordPrintable

Details

    Description

      This command works according to our documentation:

      Fix a bug +review CR @user
      

      It indeed works locally.

      However, if Fix a bug is not added to the smart commit command:

      +review CR @user
      

      The command fails with this message:

      2014-09-15 10:57:23,000 ERROR [CommitNotifier1 ] com.atlassian.fecru.plugin.commithook.internal.DefaultCommitHookManager DefaultCommitHookManager-handleCommit - Error processing commit hook Review Creation
      java.lang.RuntimeException: java.lang.ArrayIndexOutOfBoundsException: 0
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.processHook(ReviewCommitHook.java:103)
      	at com.atlassian.fecru.plugin.commithook.internal.DefaultCommitHookManager.handleCommit(DefaultCommitHookManager.java:223)
      	at com.atlassian.fecru.plugin.commithook.internal.DefaultCommitHookManager.handleCommit(DefaultCommitHookManager.java:192)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at com.atlassian.event.internal.SingleParameterMethodListenerInvoker.invoke(SingleParameterMethodListenerInvoker.java:36)
      	at com.atlassian.event.internal.AsynchronousAbleEventDispatcher$1$1.run(AsynchronousAbleEventDispatcher.java:48)
      	at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)
      	at com.atlassian.event.internal.AsynchronousAbleEventDispatcher.dispatch(AsynchronousAbleEventDispatcher.java:107)
      	at com.atlassian.event.internal.LockFreeEventPublisher$Publisher.dispatch(LockFreeEventPublisher.java:227)
      	at com.atlassian.event.internal.LockFreeEventPublisher.publish(LockFreeEventPublisher.java:82)
      	at com.atlassian.fisheye.event.FisheyeEventPublisher$EventPublication.publish(FisheyeEventPublisher.java:66)
      	at com.atlassian.fisheye.event.FisheyeEventPublisher.publish(FisheyeEventPublisher.java:38)
      	at com.cenqua.fisheye.rep.CommitEventGenerator$CommitEventNotifier$1.apply(CommitEventGenerator.java:274)
      	at com.cenqua.fisheye.rep.CommitEventGenerator$CommitEventNotifier$1.apply(CommitEventGenerator.java:257)
      	at com.cenqua.fisheye.rep.RepositoryHandle.withEngine(RepositoryHandle.java:507)
      	at com.cenqua.fisheye.rep.CommitEventGenerator$CommitEventNotifier.run(CommitEventGenerator.java:257)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:744)
      Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.stripCommand(ReviewCommitHook.java:212)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.createAndStartReview(ReviewCommitHook.java:187)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.createReview(ReviewCommitHook.java:166)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.access$000(ReviewCommitHook.java:37)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook$1.perform(ReviewCommitHook.java:86)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook$1.perform(ReviewCommitHook.java:83)
      	at com.atlassian.crucible.spi.impl.DefaultImpersonationService.doOperationAsUser(DefaultImpersonationService.java:122)
      	at com.atlassian.crucible.spi.impl.DefaultImpersonationService.doAsUser(DefaultImpersonationService.java:45)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:309)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150)
      	at org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:80)
      	at com.cenqua.crucible.hibernate.WithSessionAspect.doCloseSession(WithSessionAspect.java:37)
      	at sun.reflect.GeneratedMethodAccessor61.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:621)
      	at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:610)
      	at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:65)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161)
      	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:89)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
      	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
      	at com.sun.proxy.$Proxy64.doAsUser(Unknown Source)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at com.atlassian.plugin.osgi.hostcomponents.impl.DefaultComponentRegistrar$ContextClassLoaderSettingInvocationHandler.invoke(DefaultComponentRegistrar.java:129)
      	at com.sun.proxy.$Proxy131.doAsUser(Unknown Source)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at com.atlassian.plugin.osgi.bridge.external.HostComponentFactoryBean$DynamicServiceInvocationHandler.invoke(HostComponentFactoryBean.java:154)
      	at com.sun.proxy.$Proxy131.doAsUser(Unknown Source)
      	at com.atlassian.fecru.plugin.commithook.review.ReviewCommitHook.processHook(ReviewCommitHook.java:83)
      	... 21 more
      

      As a consequence, no review is created.

      It looks like this issue is specific for Subversion.

      Attachments

        Activity

          People

            dlahn David Lahn (Inactive)
            fkraemer Felipe Kraemer
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 5m
                5m