Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-5139

Better handling slurping a git repo, which has no tags.

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Duplicate
    • 3.5.0
    • None
    • None
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      When a git repo is being slurped by FishEye, and it has no tags yet, FishEye logs the following at INFO:

      2014-04-08 01:21:58,387 DEBUG [IncrPing1 STASH-audit-plugin ] fisheye RepositoryStatus-setMessage - Status change [STASH-audit-plugin]: Processing tags
      2014-04-08 01:21:58,387 DEBUG [IncrPing1 STASH-audit-plugin ] fisheye LoggingProcessMonitor-onBeforeStart - Starting process: /usr/bin/git show-ref -d --tags
      2014-04-08 01:21:58,493 DEBUG [IncrPing1 STASH-audit-plugin ] fisheye LoggingProcessMonitor-onAfterFinished - Finished process: /usr/bin/git show-ref -d --tags took 106ms
      2014-04-08 01:21:58,493 INFO  [IncrPing1 STASH-audit-plugin ] fisheye LoggingProcessMonitor-onAfterFinished - Exception executing command "/usr/bin/git show-ref -d --tags" Non-zero exit code: 1
      2014-04-08 01:21:58,494 DEBUG [IncrPing1 STASH-audit-plugin ] fisheye RepositoryStatus-setMessage - Status change [STASH-audit-plugin]: Finished processing tags
      2014-04-08 01:21:58,494 DEBUG [IncrPing1 STASH-audit-plugin ] fisheye Timer-output - <- slurp of STASH-audit-plugin  time 212 millis mem_usage = 624641320 heapsize = 2141061120 freemem = 1516419800
      
      

      Indeed - that repo has no tags.
      And - git handles this by exiting with exit code 1.

      STASH-audit-plugin/clone$ /usr/bin/git show-ref -d --tags
      STASH-audit-plugin/clone$ echo $?
      1
      

      Can we stop the git client from throwing an exception for this git operation, since having no tags is quite common, and the message that there was an exception could be disconcerting to some users.

      Attachments

        Issue Links

          Activity

            People

              cmacneill Conor
              npellow Nick
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: