Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-4477

Properly support SVN repositories with mixed character encodings

XMLWordPrintable

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      SVNKit renders diffs with the file encoding specified in the 'file.encoding' FISHEYE_OPTS parameter, and UTF-8 by defualt. This can be problematic if a repository contains mixed file encodings because when non-UTF8 files are written to a UTF-8 file the line ending character can be clobbered and the contents of the next line can end up on the current line. This causes problems for FIshEye's diff parser because it expects the number of lines specified in the unified diff header to match the number of lines in the diff hunk.

      Investigate what it will take to support mixed encoding repositories properly.

            [FE-4477] Properly support SVN repositories with mixed character encodings

            Marek Parfianowicz added a comment -
            Atlassian Update – 31 January 2020

            Hi everyone,

            We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not Being Considered.

            Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details.

            We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

            Kind regards
            Marek Parfianowicz
            Development Team Lead

            Marek Parfianowicz added a comment - Atlassian Update – 31 January 2020 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not Being Considered . Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Kind regards Marek Parfianowicz Development Team Lead

            Sten Pittet (Inactive) added a comment -

            rstephens could you fill in the complexity field?

            Thanks

            Sten Pittet (Inactive) added a comment - rstephens could you fill in the complexity field? Thanks

            Richard Stephens (Inactive) added a comment - - edited

            Diff observed from svnkit:

            --- test.cpp	(revision 0)
+++ test.cpp	(revision 1)
@@ -0,0 +1,7 @@
+file start
+   }
+  // vard�+
+alm�+
+file end

            There are two missing newline characters. Fisheye will misinterpret this diff. (ISO-8859-1 in this test case)

            Native SVN writes outputs the diff in the format of the encoding contained in the file.

            Richard Stephens (Inactive) added a comment - - edited Diff observed from svnkit: --- test.cpp (revision 0) +++ test.cpp (revision 1) @@ -0,0 +1,7 @@ +file start + } + // vard�+ +alm�+ +file end There are two missing newline characters. Fisheye will misinterpret this diff. (ISO-8859-1 in this test case) Native SVN writes outputs the diff in the format of the encoding contained in the file.

            Richard Stephens (Inactive) added a comment -

            SAC case: https://support.atlassian.com/browse/FSH-10874

            Richard Stephens (Inactive) added a comment - SAC case: https://support.atlassian.com/browse/FSH-10874

              Unassigned Unassigned
              rstephens Richard Stephens (Inactive)
              Votes:
              6 Vote for this issue
              Watchers:
              10 Start watching this issue

                Created:
                Updated: