Re-introduce a way to add new revisions to an existing review from JIRA

XMLWordPrintable

    • Type: Suggestion
    • Resolution: Unresolved
    • N/A
    • Component/s: None

      Before 2.9.0, our development workflow would go like this:

      • Developer commits code to Subversion and marks Jira issue as fixed (issue is assigned to nominated code reviewer).
      • Code reviewer creates a Crucible review by pressing "Create crucible review for all 2 changesets" on the Source tab in Jira.
      • Code reviewer finds issues that need fixing and makes appropriate comments in crucible review
      • Code reviewer rejects Jira issue back to developer
      • Developer makes appropriate changes, commits code to Subversion and marks Jira issue as fixed.
      • Code reviewer adds content to the existing Crucible review by pressing "Create crucible review for all 3 changesets" on the Source tab in Jira.

      This last step no longer works since the suggested reviews were removed in 2.9.0. This has a big impact for us because there is no easy way to add new changesets to an existing review. We can add them manually in Crucible, but there is a high chance that we'll miss some, especially when the review spans multiple repositories.

      How can we restore this critical feature?

      I had no particular love for the suggested reviews feature most of the time - the only good part was to update the existing review from Jira.

      I like the idea of the "update review with changesets" link in Jira. We normally only have one Crucible review per Jira issue, but I guess you could provide the user a selection list of the active reviews if there ever is more than one.

        1. UpdateCrucibleReviewFromJira.user.js
          3 kB
          Nathan Clement
        2. UpdateCrucibleReviewFromJira.user.js
          3 kB
          Nathan Clement
        3. UpdateCrucibleReviewFromJira.user.js
          3 kB
          Nathan Clement
        4. updateReview.html
          6 kB
          Nathan Clement
        5. updateReview.html
          3 kB
          Nathan Clement

              Assignee:
              Unassigned
              Reporter:
              Daniel R
              Votes:
              4 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: