Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-4335

Fisheye may miss change sets when you use include/exclude paths with git.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Long Term Backlog (View Workflow)
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: 2.8.2, 3.6.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      If a git repository has include or exclude paths specified, then GitScanner.shouldIndexChangeSet will return false if a commit only affects paths which are out of scope. This will mean that we don't actually store that changeset.

      If changesets aren't indexed and they end up having children which should be indexed, then the logs will be filled with messages like this:

          [java] 2012-10-19 14:59:24,584 WARN  - Parent not found: commit a460b4bc23a1974bbb58078c8a6bd2aef3441dca, parent 8826cc85a0ef6b50c9082bbb83ae78c35b6afd08
           [java] 2012-10-19 14:59:24,615 WARN  - Parent not found: commit e2859024dbca6325660dea2e69c5a1a61ba055c7, parent a460b4bc23a1974bbb58078c8a6bd2aef3441dca
           [java] 2012-10-19 14:59:24,666 WARN  - Could not determine position of earliest parent for changeset e2859024dbca6325660dea2e69c5a1a61ba055c7; earliestParent == null
           [java] 2012-10-19 14:59:24,715 WARN  - Cannot resolve changeset parent id a460b4bc23a1974bbb58078c8a6bd2aef3441dca for changeset e2859024dbca6325660dea2e69c5a1a61ba055c7
           [java] 2012-10-19 14:59:24,887 WARN  - Could not determine position of earliest parent for changeset 78fdb1a230626f4a6881e65aa58c47d4c52eddc9; earliestParent == null
           [java] 2012-10-19 14:59:24,955 WARN  - Cannot resolve changeset parent id a460b4bc23a1974bbb58078c8a6bd2aef3441dca for changeset e2859024dbca6325660
      

      To reproduce the issue, I've attached a sample git repo. The issue can be reproduced by adding the "/branches" directory as an include path.

      We need to determine how much of a problem this actually is - if these errors are not a problem in this case then we should maybe be logging them as DEBUG. More likely I think we always need to create a changeset object.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Last commented:
                  5 years, 1 week ago