Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-3029

HG: A Commit message ending in a line with only "P:" on it breaks indexing and repo won't index.

    XMLWordPrintable

Details

    Description

      Our internal parser looks for output in out felog extension looking like:

      M: commit message
      P: PARENTCOMMITHASH
      

      If we see a commit message like this

      M: Commit Message
      P:
      P: PARENTCOMMITHASH
      

      Our parser fails, expecting to see a F: line instead of another P: line

      We should change our parser look for a different commit message terminator that will not occur (or is less likely to occur) in a commit message itself.

      The error will look like:

      Error
      
      Repository index failed due to error com.cenqua.fisheye.rep.RepositoryClientException: com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS: extension 'felog' overrides commands: fecheck felog feparents com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS: extension 'felog' overrides commands: fecheck felog feparents com.atlassian.utils.process.ProcessException: While executing: "hg --config extensions.felog=/Users/mwatson/work/crucible/fisheye/output/dist/python/hg/hgfelog/hgfelog.py --config ui.verbose=false felog 7267310cf0ec8eb5bc90b33a6a88bf55b9158649 -p -m " com.atlassian.utils.process.ProcessException: java.lang.RuntimeException: Match failed: string [P:cb317ce5428875d2da371a55b11ba610ab68807a], pattern [F:(.*)] java.lang.RuntimeException: Match failed: string [P:cb317ce5428875d2da371a55b11ba610ab68807a], pattern [F:(.*)]

      Attachments

        Activity

          People

            Unassigned Unassigned
            mwatson@atlassian.com mwatson
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: