[CWD-4486] RestExecutor creates two connection managers

Type: Bug
Resolution: Fixed
Priority: Low
Fix Version/s: 2.9.1
Affects Version/s: 2.9.1
Component/s: None
Labels:
None

Bug Fix Policy:
View Atlassian Server bug fix policy

Since CWD-4463, RestExecutor actually creates two connection managers, one for itself and another one to construct the HttpClient. This is a bug. Only one is correctly configured and only one is shutdown when required.

is duplicated by

CWD-3977 Crowd doesn't cleanup created MultiThreadedHttpConnectionManager instances

Closed

included in

CPU-134 user-provisioning-plugin 5.1.1-D20151125T220603

mentioned in: Page Failed to load; Page Failed to load; Page Failed to load

relates to: FISH-411 Loading...

(1 relates to)

Form Name

Diego Berrueta added a comment - 09/Sep/2015 3:25 AM

The solution for the actual bug is to ensure that only one instance of the connection manager is created, and its lifecycle is managed by the RestExecutor (or more precisely, by its subclasses). This instance never leaks outside the RestExecutor.

At the same time, we noticed that the class ShutdownIgnoringHttpClientConnectionManager class (introduced in 6477c079dad0931129f892a327defd3f403ddcea because of https://ecosystem.atlassian.net/browse/FISH-411) is no longer necessary since ~~CWD-2942~~ upgraded to HttpComponents/Client 4.x, which does not have the problematic static method shutdownAll().

Diego Berrueta added a comment - 09/Sep/2015 3:25 AM The solution for the actual bug is to ensure that only one instance of the connection manager is created, and its lifecycle is managed by the RestExecutor (or more precisely, by its subclasses). This instance never leaks outside the RestExecutor. At the same time, we noticed that the class ShutdownIgnoringHttpClientConnectionManager class (introduced in 6477c079dad0931129f892a327defd3f403ddcea because of https://ecosystem.atlassian.net/browse/FISH-411 ) is no longer necessary since CWD-2942 upgraded to HttpComponents/Client 4.x, which does not have the problematic static method shutdownAll() .

Assignee:: Diego Berrueta

Reporter:: Diego Berrueta

Affected customers:: 0 This affects my team

Watchers:: 2 Start watching this issue

Created:: 09/Sep/2015 3:15 AM

Updated:: 15/Aug/2019 7:05 AM

Resolved:: 09/Sep/2015 8:28 AM

Details

Description

Attachments

Issue Links

Forms

Activity

Collapse comment: Diego Berrueta added a comment - 09/Sep/2015 3:25 AM

Expand comment: Diego Berrueta added a comment - 09/Sep/2015 3:25 AM

People

Dates