Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-3977

Crowd doesn't cleanup created MultiThreadedHttpConnectionManager instances

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Medium Medium
    • 2.9.1
    • None
    • None
    • None

      In JIRA we've noticed that crowd component that we use doesn't shutdown MultiThreadedHttpConnectionManager. This causes threads to hang after those components were disposed. In fact, crowd even introduce ShutdownIgnoringMultiThreadedHttpConnectionManager .

      All instances of MultiThreadedHttpConnectionManager should be properly cleaned up and all ShutdownIgnoringMultiThreadedHttpConnectionManager usages should be replaced with MultiThreadedHttpConnectionManager (with proper cleanup).

      Relying on MultiThreadedHttpConnectionManager#shutdownAll is really bad idea (and this method should not be used ever, as this causes deadlocks).

      Problematic instances found by thread analysis in JIRA:

      In the com.atlassian.crowd.manager.webhook.WebhookPinger.WebhookPinger()

      public WebhookPinger()
      {
          this(new HttpClient(new MultiThreadedHttpConnectionManager()));
      }
      

      In the com.atlassian.crowd.integration.rest.service.RestExecutor:

      private final ShutdownIgnoringMultiThreadedHttpConnectionManager connectionManager = new ShutdownIgnoringMultiThreadedHttpConnectionManager();
      

            [CWD-3977] Crowd doesn't cleanup created MultiThreadedHttpConnectionManager instances

            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 - restricted [ 1509887 ] New: JAC Bug Workflow v3 [ 3365773 ]
            Owen made changes -
            Symptom Severity Original: Critical [ 14430 ] New: Severity 1 - Critical [ 15830 ]
            Lukasz Pater made changes -
            Fix Version/s New: 2.9.1 [ 46094 ]
            Resolution New: Duplicate [ 3 ]
            Status Original: Open [ 1 ] New: Closed [ 6 ]
            Lukasz Pater made changes -
            Link New: This issue duplicates CWD-4486 [ CWD-4486 ]
            Marcin Kempa made changes -
            Priority Original: High [ 2 ] New: Medium [ 3 ]
            jonah (Inactive) made changes -
            Symptom Severity New: Critical [ 14430 ]
            Owen made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 [ 1392393 ] New: Simplified Crowd Development Workflow v2 - restricted [ 1509887 ]
            Owen made changes -
            Workflow Original: Crowd Development Workflow v2 [ 698925 ] New: Simplified Crowd Development Workflow v2 [ 1392393 ]
            Aleksander Mierzwicki ☁ made changes -
            Link New: This issue relates to CWD-2070 [ CWD-2070 ]
            Aleksander Mierzwicki ☁ created issue -

              Unassigned Unassigned
              amierzwicki Aleksander Mierzwicki ☁
              Affected customers:
              2 This affects my team
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: