[CWD-3090] UpdateGroupMembers fails with no UI feedback

Type: Bug
Resolution: Fixed
Priority: Medium
Fix Version/s: 2.6
Affects Version/s: 2.6
Component/s: None
Labels:
None

Bug Fix Policy:
View Atlassian Server bug fix policy

With ~~CWD-1284~~, adding a remote group as a child of a local group fails without any feedback in the UI.

If this doesn't work then there should be a clear error message.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List

Screen Shot 2013-01-31 at 3.06.30 PM.png
19 kB
31/Jan/2013 4:07 AM
Screen Shot 2013-01-31 at 3.06.41 PM.png
20 kB
31/Jan/2013 4:07 AM

Discovered while testing

CWD-1284 Allow local Crowd groups to be associated with LDAP users.

Closed

relates to

CWD-3089 Allow remote groups as children of local groups when managing groups locally in a syncing directory (Connector)

Closed

CWD-4211 Allow remote groups as children of local groups when managing groups locally and using Delegated Authentication

Gathering Interest

was split into

CWD-3097 Screen without data after failing to add a local group to a remote group

Closed

mentioned in: Wiki Page Failed to load

Form Name

Diego Berrueta added a comment - 31/Jan/2013 4:01 AM - edited

After the fix, there is an error message displayed on screen ("Group <group1> is read-only and cannot be updated"), but the page fails to render all the information. See attached screenshot. If the user switches to the 'Details' tab, another error message is displayed: "name argument cannot be null", and the group data is missing.

In the logs:

2013-01-31 14:56:56,521 http-8095-1 ERROR [crowd.plugin.web.CrowdTemplateRenderer] Error revolving template

Expression groupName is undefined on line 1, column 71 in URLTemplate.
The problematic instruction:
----------
==> ${groupName?url} [on line 1, column 69 in URLTemplate]
----------

Java backtrace for programmers:
----------
freemarker.core.InvalidReferenceException: Expression groupName is undefined on line 1, column 71 in URLTemplate.
	at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124)
	at freemarker.core.Expression.getStringValue(Expression.java:118)
	at freemarker.core.Expression.getStringValue(Expression.java:93)
	at freemarker.core.StringBuiltins$StringBuiltIn._getAsTemplateModel(StringBuiltins.java:71)
	at freemarker.core.Expression.getAsTemplateModel(Expression.java:89)
	at freemarker.core.Expression.getStringValue(Expression.java:93)
	at freemarker.core.DollarVariable.accept(DollarVariable.java:76)
	at freemarker.core.Environment.visit(Environment.java:196)
	at freemarker.core.MixedContent.accept(MixedContent.java:92)
	at freemarker.core.Environment.visit(Environment.java:196)
	at freemarker.core.Environment.process(Environment.java:176)
	at freemarker.template.Template.process(Template.java:232)
	at com.atlassian.crowd.plugin.web.CrowdTemplateRenderer.renderText(CrowdTemplateRenderer.java:103)
	at com.atlassian.crowd.plugin.web.CrowdWebFragmentHelper.renderVelocityFragment(CrowdWebFragmentHelper.java:98)
	at com.atlassian.plugin.web.model.DefaultWebLink.getRenderedUrl(DefaultWebLink.java:35)
	at com.atlassian.plugin.web.model.DefaultWebLink.getDisplayableUrl(DefaultWebLink.java:45)
	at com.atlassian.crowd.console.action.BaseAction.getDisplayableLink(BaseAction.java:461)

UPDATE: ~~CWD-3097~~ has been filled to track this secondary issue.

Diego Berrueta added a comment - 31/Jan/2013 4:01 AM - edited After the fix, there is an error message displayed on screen ("Group <group1> is read-only and cannot be updated"), but the page fails to render all the information. See attached screenshot. If the user switches to the 'Details' tab, another error message is displayed: "name argument cannot be null", and the group data is missing. In the logs: 2013-01-31 14:56:56,521 http-8095-1 ERROR [crowd.plugin.web.CrowdTemplateRenderer] Error revolving template Expression groupName is undefined on line 1, column 71 in URLTemplate. The problematic instruction: ---------- ==> ${groupName?url} [on line 1, column 69 in URLTemplate] ---------- Java backtrace for programmers: ---------- freemarker.core.InvalidReferenceException: Expression groupName is undefined on line 1, column 71 in URLTemplate. at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) at freemarker.core.Expression.getStringValue(Expression.java:118) at freemarker.core.Expression.getStringValue(Expression.java:93) at freemarker.core.StringBuiltins$StringBuiltIn._getAsTemplateModel(StringBuiltins.java:71) at freemarker.core.Expression.getAsTemplateModel(Expression.java:89) at freemarker.core.Expression.getStringValue(Expression.java:93) at freemarker.core.DollarVariable.accept(DollarVariable.java:76) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.MixedContent.accept(MixedContent.java:92) at freemarker.core.Environment.visit(Environment.java:196) at freemarker.core.Environment.process(Environment.java:176) at freemarker.template.Template.process(Template.java:232) at com.atlassian.crowd.plugin.web.CrowdTemplateRenderer.renderText(CrowdTemplateRenderer.java:103) at com.atlassian.crowd.plugin.web.CrowdWebFragmentHelper.renderVelocityFragment(CrowdWebFragmentHelper.java:98) at com.atlassian.plugin.web.model.DefaultWebLink.getRenderedUrl(DefaultWebLink.java:35) at com.atlassian.plugin.web.model.DefaultWebLink.getDisplayableUrl(DefaultWebLink.java:45) at com.atlassian.crowd.console.action.BaseAction.getDisplayableLink(BaseAction.java:461) UPDATE: CWD-3097 has been filled to track this secondary issue.

Details

Description

Attachments

Attachments

Issue Links

Forms

Activity

Collapse comment: Diego Berrueta added a comment - 31/Jan/2013 4:01 AM, Edited by Diego Berrueta - 26/Feb/2013 4:40 AM

Expand comment: Diego Berrueta added a comment - 31/Jan/2013 4:01 AM, Edited by Diego Berrueta - 26/Feb/2013 4:40 AM

People

Dates