Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-2596

Correctly handle empty/null directory attribute values when using Oracle

XMLWordPrintable

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Confluence had a bug where editing a directory would cause a data integrity violation exception on Oracle. This was because the value would get pulled in as a null (since ""==null in Oracle) and when it tried to update the value to "", it would treat it as a new row and try to do an insert again, which would fail. As a quick fix, I added code the the Embedded Crowd Hibernate 2 layer that removed all null and blank string directory attributes.

      However, in a code review, Matt R pointed out that the EMBCWD code was making assumptions about the DirectoryImpl implementation (such as attributes being a mutable map) and suggested I instead move the code down to DirectoryImpl in CWD.

        1. CWD-2596 - CR-CWD-373 Crowd Oracle Directory Editing.patch
          8 kB

            [CWD-2596] Correctly handle empty/null directory attribute values when using Oracle

            Katherine Yabut made changes -
            Workflow Original: JAC Suggestion Workflow [ 3388528 ] New: JAC Suggestion Workflow 3 [ 3630591 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 [ 1390348 ] New: JAC Suggestion Workflow [ 3388528 ]
            Issue Type Original: Improvement [ 4 ] New: Suggestion [ 10000 ]
            Status Original: Verified [ 10005 ] New: Under Consideration [ 11774 ]
            vkharisma made changes -
            Link New: This issue relates to CONFCLOUD-22469 [ CONFCLOUD-22469 ]
            Owen made changes -
            Workflow Original: Crowd Development Workflow v2 [ 338680 ] New: Simplified Crowd Development Workflow v2 [ 1390348 ]
            joe made changes -
            Link New: This issue is related to CWD-3216 [ CWD-3216 ]
            Niraj Bhawnani made changes -
            Assignee Original: Niraj Bhawnani [ nbhawnani ]
            Niraj Bhawnani made changes -
            Attachment New: CWD-2596 - CR-CWD-373 Crowd Oracle Directory Editing.patch [ 50533 ]
            Matt Ryall made changes -
            Status Original: Needs Verification [ 10004 ] New: Verified [ 10005 ]
            Matt Ryall made changes -
            Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]
            Summary Original: Don't store blank strings and null directory attribute values New: Correctly handle empty/null directory attribute values when using Oracle
            Niraj Bhawnani made changes -
            Link New: This issue relates to CONF-22469 [ CONF-22469 ]

              Unassigned Unassigned
              nbhawnani Niraj Bhawnani
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: