-
Suggestion
-
Resolution: Unresolved
Problem Definition
Nowadays when a review has comments marked as unresolved and the review author / moderator clicks the Close button this warning is shown:
As can be seen above though, that is just a warning and the author / moderator can proceed with closing the review anyway.
Suggested Solution
Block the review author / moderator from closing the review if there are unresolved comments.
Workaround
There are no known workarounds.
Notes
You can implement a workflow condition plugin with a condition similar to the following:
@Override
public ValidationResult doValidateTransition(final WorkflowTransitionContext transitionContext) {
final Review review = reviewManager.getReviewByPermaId(transitionContext.getReviewId().getId());
int unresolvedCommentCount = commentManager.getCommentCount(new CommentManagerSearchCriteria()
.review(review)
.resolutionStatus(CommentResolutionStatus.UNRESOLVED));
if (unresolvedCommentCount == 0) {
return ValidationResult.ok();
}
return ValidationResult.error("unresolved-comments",
new ResultMessage("Unresolved comments", "This review has still unresolved comments",
ImmutableList.of(
ResultAction.buildJavaScriptAction(
"Show comments",
Namespaces.buildWebResourceKey("show-unresolved-comments"),
Namespaces.buildComponentsKey("show-unresolved-comments")))));
}
Hi everyone,
We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not Being Considered.
Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details.
We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.
Kind regards
Marek Parfianowicz
Development Team Lead