Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-8388

Patch is not parsed correctly when blank characters are present at end of file paths

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Gathering Impact (View Workflow)
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: N/A
    • Fix Version/s: None
    • Component/s: Code reviews
    • Labels:
      None

      Description

      Steps to Reproduce

      1. Create git repo
      2. Add file with name containing whitespace (e.g. "fi le.txt")
      3. Make some changes in "fi le.txt"
      4. Generate diff
      5. Add patch to review patch.diff

      Expected Results

      The output patch generated by Git has two spaces added at the end of lines 3 and 4. Crucible should be able to parse diff generated by Git.

      Actual Results

      These spaces can't be parsed correctly by Crucible.

      Workaround

      Delete whitespaces from end of lines 3 and 4.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            spacuk Sebastian Pacuk
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated: