Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-7734

Oracle: NullPointerException when adding a commit with an empty path to a review

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Low
    • 3.7.1, 3.8.0
    • 3.0.2, 3.7.0
    • None

    Description

      If commit contains a empty path (eg. on SVN caused by properties set on root folder) and such commit is added to review then NullPointerException is thrown due to Oracle's empty string to null conversion. Here is a stacktrace:

      Caused by: java.lang.NullPointerException
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator.createPathIfNotFound(CrucibleRevisionCreator.java:80)
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator.access$100(CrucibleRevisionCreator.java:42)
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator$2.withSession(CrucibleRevisionCreator.java:236)
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator$2.withSession(CrucibleRevisionCreator.java:209)
                      at com.cenqua.crucible.hibernate.HibernateUtil.withRetriableTransaction(HibernateUtil.java:423)
                      at com.cenqua.crucible.hibernate.HibernateUtil.withRetriableTransaction(HibernateUtil.java:403)
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator.createRevisionsInSeparateTransaction(CrucibleRevisionCreator.java:209)
                      at com.cenqua.crucible.revision.managers.CrucibleRevisionCreator.createRevisions(CrucibleRevisionCreator.java:193)
                      at com.cenqua.crucible.model.managers.FileRevisionManager.createRevisionsFromFRIs(FileRevisionManager.java:62)
                      at com.cenqua.crucible.revision.managers.DefaultContentManager.makeCrucibleRevisions(DefaultContentManager.java:528)
                      at com.cenqua.crucible.revision.source.RepositorySource.createCrucibleFileRevisions(RepositorySource.java:480)
                      at com.cenqua.crucible.revision.source.RepositorySource.getChangeSet(RepositorySource.java:259)
                      at com.cenqua.crucible.revision.source.Source.getChangeSet(Source.java:334)
                      at com.atlassian.crucible.explorers.SimpleCrucibleChangeSetsHelper.getChangeSet(SimpleCrucibleChangeSetsHelper.java:115)
                      at com.atlassian.crucible.explorers.SimpleCrucibleChangeSetsHelper.createChangeSets(SimpleCrucibleChangeSetsHelper.java:92)
                      at com.atlassian.crucible.actions.create.EditRevisionsAjaxAction.computeRevisions(EditRevisionsAjaxAction.java:334)
                      at com.atlassian.crucible.actions.create.EditRevisionsAjaxAction.execute(EditRevisionsAjaxAction.java:261)
                      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      

      Attachments

        Issue Links

          Activity

            People

              glewandowski Grzegorz Lewandowski
              czawadka@atlassian.com Cezary Zawadka
              Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: