Max file size limit in Crucible - behaviour for revisions already added to reviews

Summary

When increasing the "Maximum Indexable File Size" setting, if a file bigger than the previous value of the Maximum Indexable File Size has already been added to at least a Crucible review, the new setting will not be applied to this file.

Even after a re-index of the repository Crucible will still show <filename> is too large to show a diff. when accessing the file in a review.

Steps to Reproduce

1. Create a Crucible review with a file bigger than the current text file size limit
2. Increase the Maximum Indexable File Size setting for the repository containing the file or for all repositories
3. Re-index the repository

   Expected Results

Crucible will now display the differences of the file.

Actual Results

Crucible does not display the differences of the file and shows:

<filename> is too large to show a diff.

Notes

• The change is immediately applied to the new files in FishEye.
• A re-index is required for this setting to be applied to historical (already indexed) files in FishEye.
• The setting can be applied to a single repository or to all repositories, however this behaviour is independent from where the setting is changed
• Note, there is no size check implemented for git yet, so this change affects non git repositories only