Details
-
Bug
-
Resolution: Duplicate
-
Low
-
None
-
3.4.1
-
None
-
None
Description
Just happened on atlaseye on bamboo-git repository. Unlikely in CRUC-6568 case there is no race condition here, review is created in single thread and files seems to get duplicated each time I create the review (tried 3 times so far).
Symptoms: (tried creating review for all changesets on https://extranet.atlassian.com/jira/browse/BDEV-4565 issue from source panel with a single click to "Create review for all 10 commits". Got several duplicated files, one example was **/AgentBootstrap.java. In the logs:
bash-3.2$ grep ReviewCreationHelper-addRevision atlassian-fisheye-2014-05-07.log | grep /AgentBootstrap 2014-05-07 08:37:16,535 DEBUG [qtp1192620997-370 ] fisheye ReviewCreationHelper-addRevision - nwlyAddedFrx: true attachMethod: ITERATION source: com.cenqua.crucible.revision.source.RepositorySource@2106ad21 max: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : 383a2feb2db992e76d3f459eaeb4c3c3a42b53b5(4) min: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : 72e59f4464de67c08471cb6478553b4ba1f8b4b1(77) frx: com.cenqua.crucible.model.FileRevisionExtraInfo@4 2014-05-07 08:37:18,399 DEBUG [qtp1192620997-370 ] fisheye ReviewCreationHelper-addRevision - nwlyAddedFrx: true attachMethod: ITERATION source: com.cenqua.crucible.revision.source.RepositorySource@2106ad21 max: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : d25f0675c1ea1e79a0ddc4c8d5515121fff0c6f7(43) min: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : f1941cafe91571d9498b01717284ce01cef16295(56) frx: com.cenqua.crucible.model.FileRevisionExtraInfo@27 2014-05-07 08:37:23,005 DEBUG [qtp1192620997-370 ] fisheye ReviewCreationHelper-addRevision - nwlyAddedFrx: false attachMethod: ITERATION source: com.cenqua.crucible.revision.source.RepositorySource@2106ad21 max: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : f1941cafe91571d9498b01717284ce01cef16295(56) min: components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java : 72e59f4464de67c08471cb6478553b4ba1f8b4b1(77) frx: com.cenqua.crucible.model.FileRevisionExtraInfo@27 2014-05-07 08:37:23,015 DEBUG [qtp1192620997-370 ] fisheye ReviewCreationHelper-addRevision - components/bamboo-agent-bootstrap/src/main/java/com/atlassian/bamboo/agent/bootstrap/AgentBootstrap.java f1941cafe91571d9498b01717284ce01cef16295 is already included in this review.
Notice nwlyAddedFrx flag, it says true twice while it should only create new frx once.