ReviewService methods using RepositorySources may fail if there's no Disposer defined

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Medium
    • 3.5.0
    • Affects Version/s: 3.0.0, 3.1.0, 3.2.0, 3.3.0, 3.4.0
    • Component/s: None

      If the thread calling ReviewService doesn't have a disposer defined (for example didn't come through CrucibleFilter), calling some methods of ReviewService will cause an exception.

      java.lang.IllegalStateException: a disposer has not been initialized for this thread
	at com.cenqua.fisheye.util.Disposer.threadInstance(Disposer.java:100)
	at com.cenqua.fisheye.rep.RepositoryHandle.acquireEngine(RepositoryHandle.java:477)
	at com.cenqua.crucible.revision.source.RepositorySource.<init>(RepositorySource.java:111)
	at com.cenqua.crucible.revision.source.DefaultSourceFactory.makeRepositorySource(DefaultSourceFactory.java:99)
	at com.cenqua.crucible.revision.source.DefaultSourceFactory.makeSource(DefaultSourceFactory.java:95)
	at com.cenqua.crucible.revision.source.DefaultSourceFactory.getSource(DefaultSourceFactory.java:71)
	at com.atlassian.crucible.spi.impl.DefaultReviewService$6.doInTransaction(DefaultReviewService.java:581)
	at com.atlassian.crucible.spi.impl.DefaultReviewService$6.doInTransaction(DefaultReviewService.java:574)
	at com.atlassian.fisheye.spi.impl.DefaultTxTemplate.execute(DefaultTxTemplate.java:126)
	at com.atlassian.fisheye.spi.impl.DefaultTxTemplate.execute(DefaultTxTemplate.java:114)
...
	at com.atlassian.crucible.spi.impl.DefaultReviewService.addChangesetsToReview(DefaultReviewService.java:574)
...

      A workaround is to manage the Disposer manually, but that's not api nor should it be exposed to the user.

              Assignee:
              Lukasz Pater
              Reporter:
              Lukasz Pater
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 7m
                  7m