• Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • None
    • Code reviews
    • None
    • 3
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      When accessing a diff in a review, we can set the view to Show All Whitespace. However, after reloading the same review diff, the view setting changed back to Hide Insignificant Whitespace.

      It would be better if there is a default view option in Administration or User Profile configuration to set the view option for Whitespace.

            [CRUC-6758] Make whitespace option preference sticky per user

            sramsesiv added a comment -

            Amazing that you think no-one cares about this. I have just started being involved in Crucible reviews (on my second one) and I am so frustrated by that setting defaulting to "Ignore whitespace" and "Ignore Blank lines" that I am ready to drop Crucible into the "well that system isn't any good" category and simply move on! Especially given how long this has been an issue and the "we don't care answers" provided by Atlassian.

            sramsesiv added a comment - Amazing that you think no-one cares about this. I have just started being involved in Crucible reviews (on my second one) and I am so frustrated by that setting defaulting to "Ignore whitespace" and "Ignore Blank lines" that I am ready to drop Crucible into the "well that system isn't any good" category and simply move on! Especially given how long this has been an issue and the "we don't care answers" provided by Atlassian.

            Dan Walker added a comment -

            Very disappointing.

            I went searching for (and started watching) this issue when I missed an important change on a code review that did not show because I forgot to switch the view whitespace setting. This clunky process is contributing to incomplete code reviews and bugs.

            Adding a new profile setting (context lines, etc. are already there!) that would allow setting a whitespace preference seems like such low-hanging fruit and would make a huge impact to those of us who are CONSTANTLY having to reset to "Show All Whitespace"

            Dan Walker added a comment - Very disappointing. I went searching for (and started watching) this issue when I missed an important change on a code review that did not show because I forgot to switch the view whitespace setting. This clunky process is contributing to incomplete code reviews and bugs. Adding a new profile setting (context lines, etc. are already there!) that would allow setting a whitespace preference seems like such low-hanging fruit and would make a huge impact to those of us who are CONSTANTLY having to reset to "Show All Whitespace"

            Atlassian Update – 11 September 2019

            Hi everyone,

            We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not being considered.

            Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details.

            We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

            Regards
            Marek Parfianowicz
            Development Team Lead
            Fisheye/Crucible Team

            Marek Parfianowicz added a comment - Atlassian Update – 11 September 2019 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not being considered . Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Regards Marek Parfianowicz Development Team Lead Fisheye/Crucible Team

            "hide insignificant whitespace" as a default is ridiculous, and it's even more ridiculous that there's no way to override that default.

            Woody Barlow added a comment - "hide insignificant whitespace" as a default is ridiculous, and it's even more ridiculous that there's no way to override that default.

            Showing all whitespace can sometimes make the coloured diff highlighting much more sensible if the changes include indentation, so I like to have it enabled.

            Chris Dore added a comment - Showing all whitespace can sometimes make the coloured diff highlighting much more sensible if the changes include indentation, so I like to have it enabled.

            It would be especially useful as a User Profile configuration, since not everyone has the same preferences. The problem I'm running into is the the Insignificant Whitespace detection doesn't work very well when reviewing Python code, because all whitespace is significant.

            Adam Kiczula added a comment - It would be especially useful as a User Profile configuration, since not everyone has the same preferences. The problem I'm running into is the the Insignificant Whitespace detection doesn't work very well when reviewing Python code, because all whitespace is significant.

              Unassigned Unassigned
              klfoong Foong (Inactive)
              Votes:
              23 Vote for this issue
              Watchers:
              11 Start watching this issue

                Created:
                Updated: