Details
-
Bug
-
Resolution: Fixed
-
Medium
-
None
-
None
-
None
Description
DefaultReviewManager.getReviewByPermaId() and other methods ask the database to do a case insensitive lookup of the review project key in the ReviewPermaId table.
Unfortunately this causes mysql to not use its perfectly good indexes and do a full table scan which can be slow.
Possible approaches to fix this:
1. (Preferred) do a case sensitive comparison and make sure that every caller of these methods will supply perma IDs with the correct case (and their callers, etc etc etc).
2. Do case sensitive lookup first. If not found, do case insensitive lookup
3. Lookup only by number component of perma ID, and filter results in java code
Attachments
Issue Links
- causes
-
CRUC-6940 Poor performance on review creation with large changeset
- Closed
- has a derivative of
-
CRUC-7305 Force upper case key in FeCru project
- Closed
- mentioned in
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...