Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6417

Better handling of Authentication Errors when manually linking a Review to a JIRA Issue

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Low
    • 3.1.0
    • 2.10.2
    • None
    • None

    Description

      If a user is not authenticated to the Remote JIRA Server when linking a JIRA issue key to a Crucible Review, the following message is displayed in the UI:

      And the following appears in the logs

      2013-03-14 20:56:35,913 DEBUG [IncrementalPinger3 Critter] fisheye LoggingProcessMonitor-onBeforeStart - Starting process: /usr/bin/git show-ref -d --tags 
      2013-03-14 20:56:35,916 DEBUG [qtp32565619-74196 ] fisheye JiraIssueServiceImpl-logException - Error retrieving issue 'JRADEV-13927' from JIRA server at https://ecosystem.atlassian.net/browse/JRADEV-13927
      com.atlassian.crucible.spi.services.NotPermittedException: com.atlassian.jira.rpc.exception.RemoteAuthenticationException: User not authenticated yet, or session timed out.
              at com.atlassian.fisheye.jira.soap.JiraUALSoapInvoker.invokeOperation(JiraUALSoapInvoker.java:42)
              at com.atlassian.fisheye.jira.soap.AbstractJiraSoapInvoker.invoke(AbstractJiraSoapInvoker.java:31)
              at com.atlassian.fisheye.jira.JiraServerImpl.invoke(JiraServerImpl.java:246)
              at com.atlassian.fisheye.jira.JiraServerImpl.getIssue(JiraServerImpl.java:251)
              at com.atlassian.fisheye.jira.issue.JiraIssueServiceImpl.retrieveJiraIssue(JiraIssueServiceImpl.java:169)
              at com.atlassian.fisheye.jira.issue.JiraIssueServiceImpl.getJiraIssue(JiraIssueServiceImpl.java:97)
              at com.atlassian.crucible.actions.create.LinkReviewToJiraAjaxAction.linkJiraKey(LinkReviewToJiraAjaxAction.java:142)
              at com.atlassian.crucible.actions.create.LinkReviewToJiraAjaxAction.execute(LinkReviewToJiraAjaxAction.java:106)
              at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
              at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
              at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      
      

      The issue key does exist, however at another JIRA instance: JDOG.
      There are a few problems here:

      1. We seem to only report one of the jira instances in the UI, and it is wrong - Ecosystem
      2. We don't provide a link to that instance to allow an end user to Authenticate
      3. We tell the end user to go looking through the logs, when what they have is a simple authentication issue which can all be sorted in the browser.

      I would like to see the following improvements made:

      • we detect authentication errors when trying to link to a JIRA server, from other errors.
      • we display all JIRA servers which were tried, and could not authenticate with - not just the first one.
      • the error messages should provide hrefs to the login pages for those failed JIRA servers

      Attachments

        Issue Links

          Activity

            People

              gcrain Geoff Crain (Inactive)
              npellow Nick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 11m
                  11m