Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6154

Crucible sends cookies for UI preferences that can end up larger than the small Jetty default of 4096, consider alternative approaches to sending UI preferences and consider increasing the Jetty default

    XMLWordPrintable

Details

    Description

      Crucible sends large cookies for UI preferences. The default limit HEAD request size for the Jetty web server used by crucible is 4096 bytes. As the cookies include a list of every open review the user has edit privileges on, this list could grow to be quite large.
      The cookie holding the list of open reviews is called "editReviewShown" and "editReviewDetailsShown".
      These are not cleared in Chrome, say when the "Continue where I left off" setting is set.

      Modern browser usage is for long running browser sessions, especially with that option set.

      We should simply limit the length of review keys in these Cookies to 20 or so. And remove them in a FIFO order

      Examine if we need to be sending these or if we could perhaps take a different approach. Look at what limits this imposes on crucible usage (max open reviews at once?).

      Examine if we should increase the default we use for jetty to, say, 16kb.

      There is a documentation page which describes how to adjust this limit.

      Attachments

        Issue Links

          Activity

            People

              lzheng Liangliang Zheng (Inactive)
              rstephens Richard Stephens (Inactive)
              Votes:
              9 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: