Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-5768

Improve Crucible's Handling of Moved Files to Allow Free-Flowing diff Across File Locations

    • 10
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      We have a lot of refactoring occurring in our project - constantly files are moving from package to package, project to project, as we see fit for organizing the code.

      Though this makes for a better-looking codebase, it is a nightmare in Crucible - the files that are moved show as "file outdated" and if the latest changeset is added, it shows the entire file as deleted. This not ideal, because the file is not deleted, it has simply moved. When this happens we must find the new file location and add it to the review; but even then that leaves us with 2 files and a broken "diff" from the original change in the original file location to the last change in the current/new file location.

      What I would like to see is for Crucible to do one or both (and let the user choose on a file-by-file or project-by-project basis) of the following:

      1. Track the move/rename and allow the diff to encompass both the original file location and the new file location.
        • I realize that not everyone might want Crucible to work this way (some people might want to see the new location of the file to ensure it is appropriately located) - however this is still a good option for a user to choose from to suit their needs.
      2. When the user chooses "Add Latest" to the review, and the file has been moved: prompt to add the file at its new location & mark the original as deleted, rather than exclusively updating the original file location to deleted (as it does today).
        • This is also a good option - no one wants to just add the deleted file and leave it that way in the review when there has been subsequent changes made to the file after it has been moved.

      Example:
      File Meat.java was moved in Version Control from /src/path1 to /src/path2, and then some subsequent changes were made. In Crucible it shows the file at/src/path1/Meat.java as outdated. If "Update to Latest" were chosen, Meat.java would then be marked as deleted in the review - not ideal as it is not deleted!

      On a sidenote regarding this example:
      If I go to the /src/path2/Meat.java in Fisheye, I can see all of the history (Good ). This type of a view is really what I want to see in Crucible, as it unites the original file location and the new file location to seamlessly cover the changes to the file in both the original and new location, and permits diffs between the file when it existed in its old location and its new location.

      FYI - We are using Subversion, but this improvement should be VC-agnostic: it should work on any version control that tracks file moves.

            [CRUC-5768] Improve Crucible's Handling of Moved Files to Allow Free-Flowing diff Across File Locations

            Atlassian Update – 19 May 2020

            Hi everyone,

            thank you very much for reporting this suggestion and your involvement in the conversations around it. This suggestion is in the 'Reviewing' state which means it awaits assessment by our team.

            As Fisheye and Crucible have entered basic maintenance mode, our team currently focuses more on bug-fixes and platform updates rather than on feature development. We may still deliver some small improvements if they fit into the maintenance theme. However, suggestions which have been assessed already and are in the Under consideration state have higher priority.

            It means it may take time until we review this suggestion and decide whether to put it on the roadmap or reject it. You can expect an update from us in couple of months. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

            Kind regards
            Marek Parfianowicz
            Development Team Lead
            Fisheye/Crucible Team

            Marek Parfianowicz added a comment - Atlassian Update – 19 May 2020 Hi everyone, thank you very much for reporting this suggestion and your involvement in the conversations around it. This suggestion is in the 'Reviewing' state which means it awaits assessment by our team. As Fisheye and Crucible have entered basic maintenance mode , our team currently focuses more on bug-fixes and platform updates rather than on feature development. We may still deliver some small improvements if they fit into the maintenance theme. However, suggestions which have been assessed already and are in the Under consideration state have higher priority. It means it may take time until we review this suggestion and decide whether to put it on the roadmap or reject it. You can expect an update from us in couple of months. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Kind regards Marek Parfianowicz Development Team Lead Fisheye/Crucible Team

            This is probably our #1 complaint with crucible.

            Colin Smith added a comment - This is probably our #1 complaint with crucible.

            Is there any chance this issue will be dealt with?

            We really have a hard time reviewing changes within one file. If the file moves or is renamed during a development/ review phase, depending on the reviewer's state the file really looks weird (and is marked as deleted) which adds a lot of confusion.

            We really would appreciate some improvement.

            Kevin Böckler added a comment - Is there any chance this issue will be dealt with? We really have a hard time reviewing changes within one file. If the file moves or is renamed during a development/ review phase, depending on the reviewer's state the file really looks weird (and is marked as deleted) which adds a lot of confusion. We really would appreciate some improvement.

            Martin Wiklander added a comment - - edited

            I would also like to have this bug fixed. This cause a lot of confusion and it would help us to have renames tracked and the comments moved together with the file. 

            Martin Wiklander added a comment - - edited I would also like to have this bug fixed. This cause a lot of confusion and it would help us to have renames tracked and the comments moved together with the file. 

            Please fix this! It's seems odd that renames/moves aren't tracked in the first place. All the comments from the file should still be on the renamed version of the file.

            Shane Wignall added a comment - Please fix this! It's seems odd that renames/moves aren't tracked in the first place. All the comments from the file should still be on the renamed version of the file.

            This bug should be a major bug.  Do the authors of crucible actually use it to review/refactor their own code?  Its horrible, even for moving files into a new location as a comment as a result of a new review, it shows the moved files as new files and all the comments and changes from the other location are not moved with it.  This bug has been open for 7 years and really needs to be fixed.

            philip dicke added a comment - This bug should be a major bug.  Do the authors of crucible actually use it to review/refactor their own code?  Its horrible, even for moving files into a new location as a comment as a result of a new review, it shows the moved files as new files and all the comments and changes from the other location are not moved with it.  This bug has been open for 7 years and really needs to be fixed.

            When today I committed a lot of files, changed and renamed at once, I really felt sorry for the reviewer, but I could do nothing with it.
            Even combining crucible with another review tool cannot help review this since you cannot even copy-paste the file contents to another window

            Yan EyeScream added a comment - When today I committed a lot of files, changed and renamed at once, I really felt sorry for the reviewer, but I could do nothing with it. Even combining crucible with another review tool cannot help review this since you cannot even copy-paste the file contents to another window

            The current behavior is really bad. Sounds like a good reason to choose another coding review tool.

            Alexander Kouznetsov added a comment - The current behavior is really bad. Sounds like a good reason to choose another coding review tool.

              Unassigned Unassigned
              deezerdeezer Deezer Deezer
              Votes:
              54 Vote for this issue
              Watchers:
              29 Start watching this issue

                Created:
                Updated: