Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-3751

Precommit patch files generate incorrect diffs.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Not a bug
    • High
    • None
    • 2.3.3
    • None
    • None
    • Client system
      Win7 x64
      Chrome Browser

      Server config - Unsure

    Description

      We perform all our code reviews before commit. This means the only way we have to attach changes, is either by uploading the files directly, or by uploading a SVN patch.

      When we upload the SVN patch files, we can see the diffs, however, it appears that the changed code shows up at incorrect
      lines.

      For example, this is what the curcible shows

      When I apply this patch on the checked out branch it shows up correctly

      If you notice between the two images, you will notice that the lines are transposed. The tortoise diff shows the correct position. This has been verified by looking into the actual file, once the patch was downloaded from the crucible review and applied to the unmodified source file.

      Also, looking at the SVN diff file, I see the following

      If these line numbers are not correct, crucible is unusable.

      Also, It appears that when we upload the files, the diffs do not show up.

      Attachments

        1. svn1.JPG
          svn1.JPG
          38 kB
        2. file1.JPG
          file1.JPG
          14 kB
        3. diff1.JPG
          diff1.JPG
          26 kB
        4. cru1.JPG
          cru1.JPG
          25 kB

        Activity

          People

            Unassigned Unassigned
            310884c35bcd Vaibhav Tyagi
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: