Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-3378

Consider use of p4 shelve / p4 unshelve for pre commit reviews

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • None
    • Code reviews
    • None
    • 29

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      The latest version of perforce adds two new commands p4 shelve and p4 unshelve.

      #208746 (Bug #15043) **
      Two new commands, 'p4 shelve' and 'p4 unshelve', enable
      developers to store and retrieve files on the Perforce server
      without submitting them. These commands make multi-tasking,
      code sharing, testing and review much easier and more practical.
      Users gain access to shelved files and their content through
      'describe', 'changes' 'fstat', 'diff', 'diff2', 'files' and
      'print'. See 'p4 help shelve/unshelve' for more information.

      So it allows you to store a potential changeset on the server without doing a p4 submit. Might be a nice way to handle pre-commit reviews.

            [CRUC-3378] Consider use of p4 shelve / p4 unshelve for pre commit reviews

            Marek Parfianowicz added a comment -

            Hello Allen!

            We analyse Suggestions every week, we already evaluated over 60 of them, there are about 30 Suggestions remaining (in the "Reviewing" state) so please give us a bit more time. I encourage you to monitor our public dashboard:
            https://jira.atlassian.com/secure/Dashboard.jspa?selectPageId=90494

            Kind regards
            Marek Parfianowicz
            Development Team Lead

            Marek Parfianowicz added a comment - Hello Allen! We analyse Suggestions every week, we already evaluated over 60 of them, there are about 30 Suggestions remaining (in the "Reviewing" state) so please give us a bit more time. I encourage you to monitor our public dashboard: https://jira.atlassian.com/secure/Dashboard.jspa?selectPageId=90494 Kind regards Marek Parfianowicz Development Team Lead

            Yunseok Allen Lee added a comment -

            Any Update here?

             

            Yunseok Allen Lee added a comment - Any Update here?  

            Ming-Jeng Lee added a comment -

            Renjith Pillai, can I have a copy of the add-on? My email address ming-jeng.lee@watchguard.com.

            Thanks,

            Ming-Jeng Lee added a comment - Renjith Pillai, can I have a copy of the add-on? My email address ming-jeng.lee@watchguard.com. Thanks,

            mikeada added a comment -

            Where do we get this aforementioned plugin?  I don't see it in the marketplace.  We're trying to solve this same problem and considering testing swarm.  Thanks!

            mikeada added a comment - Where do we get this aforementioned plugin?  I don't see it in the marketplace.  We're trying to solve this same problem and considering testing swarm.  Thanks!

            QAP added a comment -

            See my comment above.

            QAP added a comment - See my comment above .

            James C. Papp added a comment -

            Any update one this? I knew about stream support in Perforce not being there but did not know about the lack of shelf support. We are in our 30 day eval, but without this, it is probably a deal breaker. I see some people mention some type of add-in. Is this from Atlassian?

            James C. Papp added a comment - Any update one this? I knew about stream support in Perforce not being there but did not know about the lack of shelf support. We are in our 30 day eval, but without this, it is probably a deal breaker. I see some people mention some type of add-in. Is this from Atlassian?

            Gabor Maghera added a comment -

            Same here. We've moved to using Swarm. But still it's good to finally see progress on improving Perforce support (Bamboo could use some too ).

            Gabor Maghera added a comment - Same here. We've moved to using Swarm. But still it's good to finally see progress on improving Perforce support (Bamboo could use some too ).

            Ari Brown added a comment -

            We've basically moved everything to Git/BitBucket - irrelevant now, except for a few teams lingering in the old code.

            Ari Brown added a comment - We've basically moved everything to Git/BitBucket - irrelevant now, except for a few teams lingering in the old code.

            Rob Stewart added a comment -

            We might be interested in that plugin, too, but we've added shelveset support to crucible.py.

            Rob Stewart added a comment - We might be interested in that plugin, too, but we've added shelveset support to crucible.py.

            michel_samia added a comment -

            I'd also love to get this plugin!

            michel_samia added a comment - I'd also love to get this plugin!

              Unassigned Unassigned
              andrew.myers Andrew Myers [Atlassian]
              Votes:
              171 Vote for this issue
              Watchers:
              114 Start watching this issue

                Created:
                Updated: