Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-1841

inline comments break diff rendering when source lines are short

    XMLWordPrintable

Details

    • Bug
    • Resolution: Obsolete
    • Medium
    • N/A
    • 2.0.2, 2.1-M1
    • None
    • None
    • Safar 4.0.2

    Description

      Steps to reproduce:
      1. Select a file/diff with short source lines or adjust the browser width so that there is lots of whitespace between the rightmost edge of the source and the right side of the viewport.
      2. Click on a source line to create an inline comment.

      Expected:

      • comment edit form pops up.

      Actual:

      • comment edit form pops up.
      • the tetris, line number, and diff marker columns expand, throwing the alignment of the unifed diff out (see the screen shots).

      The diff alignment is still broken after:

      • immediately posting the inline comment, and
      • page reload.

      Attachments

        1. Picture 6.png
          166 kB
          Agnes Ro
        2. safari4-inline-comment-bug-onclick.png
          98 kB
          Nicolas Venegas
        3. safari4-inline-comment-bug-posted.png
          106 kB
          Nicolas Venegas
        4. safari4-inline-comment-bug-reload.png
          104 kB
          Nicolas Venegas
        5. safari4-inline-comment-bug-whitespace.png
          116 kB
          Nicolas Venegas

        Issue Links

          Activity

            People

              Unassigned Unassigned
              nvenegas Nicolas Venegas (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: