• Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 4.9.1
    • Server administration
    • None
    • Crucible Standalone, Fedora Linux
    • 5
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Use case: I use the monit daemon on my server to make sure the production services stay running; this requires having a PID file for each service; monit then knows what the process ID is and can check whether it's up, and take appropriate action.

      The attached version of fisheyectl.sh places the pid file at the location specified by the FISHEYE_PID environment variable (default FISHEYE_INST/var/fisheye.pid). It also uses the pidfile to check for a running instance of Crucible, and prevents the service from being started twice.

      I'm putting my modifications in the public domain so that this can be added to the shipped fisheyectl.sh. Can you review and include in a future release if appropriate? Credit would be appreciated but is not required.

      Thanks!

            [CRUC-1050] Add support for PID file

            This ticket will be released in scope of 4.9.1 release

            Oleh Shchur added a comment - This ticket will be released in scope of 4.9.1 release

            12 years and 3 months. oof.

            Daniel Frising added a comment - 12 years and 3 months. oof.

            11 years, and this basic Linux feature is still missing...

            Snorre Selmer added a comment - 11 years, and this basic Linux feature is still missing...

            +1 (year). This is really annoying. Starting daemons (services) without proper os integration is just going back decades ..

            Adrian Wiedemann added a comment - +1 (year). This is really annoying. Starting daemons (services) without proper os integration is just going back decades ..

            Make that 8 (in words: eight) years. With the move of major Linux distributions do systemd, where the pidfile is used in service definitions, you would think that this gains some importance, especially when it's so easy to fix.

            Gerald Schneider added a comment - Make that 8 (in words: eight) years. With the move of major Linux distributions do systemd, where the pidfile is used in service definitions, you would think that this gains some importance, especially when it's so easy to fix.

            At a bare minimum, all that is really needed is adding this line after "nohup..." in fisheyectl.sh:

            echo $! > $FISHEYE_INST/var/fisheye.pid
            

            Not sure why anyone would object to that change, especially to help close an almost 6 year old issue...

            Kevin Radke added a comment - At a bare minimum, all that is really needed is adding this line after "nohup..." in fisheyectl.sh: echo $! > $FISHEYE_INST/ var /fisheye.pid Not sure why anyone would object to that change, especially to help close an almost 6 year old issue...

            i tried to let them fix it by they said its not a problem for them
            https://support.atlassian.com/servicedesk/customer/bsp/installation-query-15072

            i also made a small startup scrtip fix to fix this

            this is my startupscript
            https://github.com/ramonskie/bamboo/blob/master/templates/default/bamboo.init.erb

            but using the pid file also represented a different problem as mentioned in
            https://support.atlassian.com/servicedesk/customer/bsp/installation-query-15072

            that it would not correctly kill the pid when it tomcat things it hangs
            so i needed to adjust the stop-bamboo.sh
            https://github.com/ramonskie/bamboo/blob/master/templates/default/stop-bamboo.sh.erb

            please note that these are chef templates so you need to change the variables
            to fit your own

            Deleted Account (Inactive) added a comment - i tried to let them fix it by they said its not a problem for them https://support.atlassian.com/servicedesk/customer/bsp/installation-query-15072 i also made a small startup scrtip fix to fix this this is my startupscript https://github.com/ramonskie/bamboo/blob/master/templates/default/bamboo.init.erb but using the pid file also represented a different problem as mentioned in https://support.atlassian.com/servicedesk/customer/bsp/installation-query-15072 that it would not correctly kill the pid when it tomcat things it hangs so i needed to adjust the stop-bamboo.sh https://github.com/ramonskie/bamboo/blob/master/templates/default/stop-bamboo.sh.erb please note that these are chef templates so you need to change the variables to fit your own

            IT Admin added a comment -

            Same here.

            IT Admin added a comment - Same here.

            please merge this

            Deleted Account (Inactive) added a comment - please merge this

            Christian Schlaefcke added a comment - - edited

            Now it's more than 4 years

            Would also be needed for a smooth systemd integration - please implement the suggested change. It does not look like a big effort.

            Christian Schlaefcke added a comment - - edited Now it's more than 4 years Would also be needed for a smooth systemd integration - please implement the suggested change. It does not look like a big effort.

              Unassigned Unassigned
              ee93ccb23ea2 Peter Kolbus
              Votes:
              21 Vote for this issue
              Watchers:
              15 Start watching this issue

                Created:
                Updated:
                Resolved: