Issue Summary

We upgraded to 7.4.3 and found that the previous method of customizing invalid SAML messages is no longer working. Before this upgrade, we made changes to the confluence/WEB-INF/atlassian-bundled-plugins/atlassian-authentication-plugin-xx.xx.xx.jar  and updated the jar file, however this method no longer seems to work.

Steps to Reproduce

1. Setup an OKTA developer account and then configure an OKTA instance and connect it to a Confluence 7.4.3 Data Center instance using the instructions found here.
2. Use the instructions found here to extract the contents of the atlassian-authentication-plugin-3.2.1.jar file, open the atlassian-plugin.properties file in a text editor and update this line so that it says something else:

   #---------------------Authentication failed---------------------    
   authentication.failed.header= TTT We can''t log you in right now
   

1. Re-compress the JAR file and then use it to replace the existing one in the WEB-INF/atlassian-bundled-plugins directory.
2. Restart Confluence
3. Create a user in OKTA, assign that user to the Confluence app, but do NOT add the user to Confluence
4. Try to login to Confluence

Expected Results

The error message on the failed login screen should be updated to the string entered in step 2 above.

Actual Results

The error message does not change.

Please confirm if this is a bug or if the procedure for editing this error message has changed with Confluence 7.4.3.

Workaround

You can workaround this issue by extracting the atlassian-authentication-plugin-3.2.1 jar and then going into the templates directory and updating the error-page-generic.soy file like we have updated the one attached to this issue, however we would still like to understand why updating the authentication.failed.header or the authentication.failed.message value in the atlassian-plugin.properties file no longer works. Ideally, we would just like to have a dialog box, field/UI where we can enter this custom text and should be done. It is also inconvenient and time consuming to have to figure out how to update this error screen a new way when we update Confluence.