Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-56307

Companion app's "Launch on startup" does not work if Windows user has username with spaces

XMLWordPrintable

      The Atlassian Companion app has an option to "Launch on startup", which creates a registry entry in Windows, for just that.
      There is an issue with Windows however, where sometimes, it's unable to launch a program if there's space in between a user name.

      For example,
      Does not work: C:\Users\user name\AppData\Local\atlassian-desktop-companion\Atlassian Companion.exe --was-opened-at-login
      Works: C:\Users\username\AppData\Local\atlassian-desktop-companion\Atlassian Companion.exe --was-opened-at-login

      This seems to be a Windows issue, since it should be able to launch the app, even if the path has spaces in it, but it just does not work on certain Windows install for some reason.
      https://answers.microsoft.com/en-us/windows/forum/all/on-startup-windows-tries-to-open-a-file-but-cant/420aae7f-be93-4f6b-9bc5-b75d01c0fca0
      https://stackoverflow.com/questions/2919286/getting-the-username-from-the-hkey-users-values
      https://superuser.com/questions/479105/how-can-i-format-this-path-to-work-as-registry-key-value
      https://answers.microsoft.com/en-us/windows/forum/windows_10-other_settings/windows-10-upgrade-issue-with-space-in-username/3ea1a411-2c59-4d2a-bda1-d48b9793231f

      Workaround:
      We can workaround the issue by editing the registry entry, and add quotes around the whole path.
      HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run\com.squirrel.atlassian-desktop-companion.AtlassianCompanion"C:\Users\user name\AppData\Local\atlassian-desktop-companion\Atlassian Companion.exe --was-opened-at-login".

      This works, but once the App starts, it updates the path again, and removed the quotes, and so we have to do this again before restart, after the app starts.

      Suggestion:
      We should add quotes around the path as a preventative measure, so that users with this issue are able to have the app launch on startup.

            [CONFSERVER-56307] Companion app's "Launch on startup" does not work if Windows user has username with spaces

            Alex K added a comment -

            A fix for this issue is available in Companion 0.6.1. View the Release Notes to see what other issues are resolved.

            If Companion is installed via the MSI, then it will need to be manually updated to the new version.

            Alex K added a comment - A fix for this issue is available in Companion 0.6.1. View the Release Notes to see what other issues are resolved. If Companion is installed via the MSI, then it will need to be manually updated to the new version .

            Dalectric added a comment - - edited

            Is this going to get fixed soon? We are still waiting on this update before we can update our Confluence version

            Dalectric added a comment - - edited Is this going to get fixed soon? We are still waiting on this update before we can update our Confluence version

            Dalectric added a comment -

            Thanks for the response Niraj.

            There is now another security advisory that affects me

            https://confluence.atlassian.com/doc/confluence-security-advisory-2019-04-17-968660855.html

            I can disable the Download All attachments feature, but this will affect some of my users so is less than ideal.

            Dalectric added a comment - Thanks for the response Niraj. There is now another security advisory that affects me https://confluence.atlassian.com/doc/confluence-security-advisory-2019-04-17-968660855.html I can disable the Download All attachments feature, but this will affect some of my users so is less than ideal.

            Niraj Bhawnani added a comment -

            Hi eddy5,

            Sorry for the lack of update on this ticket. We have done some preliminary investigation into this issue and found that the issue lies entirely inside the Atlassian Companion app. It's worth noting that the Companion app is upgraded automatically (unless installed via MSI) and as such, if you do upgrade to a version of Confluence that requires the companion app to edit files, once this bug is fixed the fix should roll out automatically. i.e. you won't be "stuck" with a broken version.

            That said, we are aware of how this bug can get in the way of work for some users/organisations so we will be scheduling it to be fixed in the coming weeks. Sorry for any inconvenience caused.

            Thanks,
            Niraj Bhawnani
            Senior Development Team Lead, Confluence Server
            Atlassian

            Niraj Bhawnani added a comment - Hi eddy5 , Sorry for the lack of update on this ticket. We have done some preliminary investigation into this issue and found that the issue lies entirely inside the Atlassian Companion app. It's worth noting that the Companion app is upgraded automatically (unless installed via MSI) and as such, if you do upgrade to a version of Confluence that requires the companion app to edit files, once this bug is fixed the fix should roll out automatically. i.e. you won't be "stuck" with a broken version. That said, we are aware of how this bug can get in the way of work for some users/organisations so we will be scheduling it to be fixed in the coming weeks. Sorry for any inconvenience caused. Thanks, Niraj Bhawnani Senior Development Team Lead, Confluence Server Atlassian

            Dalectric added a comment -

            After this recent announcement I am now stuck with a version that has this flaw as I cannot upgrade to the latest version and am already on 6.7.2 so cannot downgrade to 6.6.x stream

            https://confluence.atlassian.com/doc/confluence-security-advisory-2019-03-20-966660264.html?subid=523504633&jobid=104007885&utm_campaign=Confluence+Server-advisory_march-2019_EML-4573&utm_medium=email&utm_source=alert-email

            Please fix this

            Dalectric added a comment - After this recent announcement I am now stuck with a version that has this flaw as I cannot upgrade to the latest version and am already on 6.7.2 so cannot downgrade to 6.6.x stream https://confluence.atlassian.com/doc/confluence-security-advisory-2019-03-20-966660264.html?subid=523504633&jobid=104007885&utm_campaign=Confluence+Server-advisory_march-2019_EML-4573&utm_medium=email&utm_source=alert-email Please fix this

            Dalectric added a comment -

            Is there a timescale for this to bug to be fixed?

            At the moment this a total blocker for me to upgrade to the later versions of Confluence that use this app.

            Dalectric added a comment - Is there a timescale for this to bug to be fixed? At the moment this a total blocker for me to upgrade to the later versions of Confluence that use this app.

            Dalectric added a comment -

            I am testing Windows 10 in our organisation and I note that this issue does not occur on 2 different machines I have tested this on.

            The vast majority of our computers are still on Windows 7 however so this will still affect most of my users.

            Dalectric added a comment - I am testing Windows 10 in our organisation and I note that this issue does not occur on 2 different machines I have tested this on. The vast majority of our computers are still on Windows 7 however so this will still affect most of my users.

            Dalectric added a comment - - edited

            This is an upgrade blocker for me at the moment. This will cause many (if not all) of my users an issue and I'm not willing to support this, especially as there's no viable workaround as the app overwrites whatever registry setting is changed to try and fix it.

            Note: the line in the Works example appears to be missing the double quotes around the executable path. It should be

            "C:\Users\user name\AppData\Local\atlassian-desktop-companion\Atlassian Companion.exe"

            Dalectric added a comment - - edited This is an upgrade blocker for me at the moment. This will cause many (if not all) of my users an issue and I'm not willing to support this, especially as there's no viable workaround as the app overwrites whatever registry setting is changed to try and fix it. Note: the line in the Works example appears to be missing the double quotes around the executable path. It should be "C:\Users\user name\AppData\Local\atlassian-desktop-companion\Atlassian Companion.exe"

              Unassigned Unassigned
              smaran Sattesh M
              Affected customers:
              1 This affects my team
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: