Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-5556

Can not add groups with commas in the name to space permissions

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Medium Medium
    • 2.3
    • 5.5, 5.5.1
    • None

      Whilst it is possible to create groups in Confluence with commas in the name, it is not possible to add these groups to the space's permission. The group name is being treated as two separate groups, separated by the comma.

            [CONFSERVER-5556] Can not add groups with commas in the name to space permissions

            Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for quite some time with very little progress being made. Rather than leave this issue here I'm going to close this out as won't fix. I believe this better reflects the status of the issue.

            Regards
            Steve Haffenden
            Confluence Bugmaster

            Steve Haffenden (Inactive) added a comment - Thanks for taking the time to raise this issue. As you are no doubt aware this issue has been on our backlog for quite some time with very little progress being made. Rather than leave this issue here I'm going to close this out as won't fix. I believe this better reflects the status of the issue. Regards Steve Haffenden Confluence Bugmaster

            Don Willis added a comment - - edited

            I've attempted to make everybody happy.

            There are various other oddnesses that occur when groups or users have commas in the name, (eg a comma user's personal space gets a comma in the name even though spaces aren't allowed in space names). Therefore users and groups containing commas and backslashes have been disallowed.

            However, since they may exist anyway due to LDAP or indeed old confluence instances, I have made both usernames and group names in text fields be escaped with backslashes.

            IE a group named "the,\group" will be displayed in text fields as "the\,\\group".

            This has been implemented in page permissions, global permissions and space permissions.

            Don Willis added a comment - - edited I've attempted to make everybody happy. There are various other oddnesses that occur when groups or users have commas in the name, (eg a comma user's personal space gets a comma in the name even though spaces aren't allowed in space names). Therefore users and groups containing commas and backslashes have been disallowed. However, since they may exist anyway due to LDAP or indeed old confluence instances, I have made both usernames and group names in text fields be escaped with backslashes. IE a group named "the,\group" will be displayed in text fields as "the\,\\group". This has been implemented in page permissions, global permissions and space permissions.

            Matt Ryall added a comment -

            Unfortunately, commas are supported in LDAP, so we need to support commas in group names in the group picker. Users may not be able to change the LDAP groups which are assigned by their organisation.

            I think the best solution is simply an escape character which escapes the commas. It shouldn't be necessary for the user to understand this, as long as the group picker popup inserts the escape characters when populating the text field as it closes.

            Note that this problem affects global permissions and page restrictions as well, because they use the same group picker code.

            Matt Ryall added a comment - Unfortunately, commas are supported in LDAP, so we need to support commas in group names in the group picker. Users may not be able to change the LDAP groups which are assigned by their organisation. I think the best solution is simply an escape character which escapes the commas. It shouldn't be necessary for the user to understand this, as long as the group picker popup inserts the escape characters when populating the text field as it closes. Note that this problem affects global permissions and page restrictions as well, because they use the same group picker code.

            jens added a comment -

            We shouldn't allow commas in the group name. Otherwise we will run into troubles in all sorts of places.

            A workaround for existing groups is to have a space instead of the comma when choosing the groups. This should also work as a separator.

            jens added a comment - We shouldn't allow commas in the group name. Otherwise we will run into troubles in all sorts of places. A workaround for existing groups is to have a space instead of the comma when choosing the groups. This should also work as a separator.

              shaffenden Steve Haffenden (Inactive)
              ewong@atlassian.com Ernest Wong (Inactive)
              Affected customers:
              2 This affects my team
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: