Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-52441

Emoticon is changing to image after the first save and edit of the page

       Summary

      Emoticons macro is changing to image after the first save and edit of the page.

      Steps to Reproduce

      1. Create a page and add an emoticon by typing in the keyboard or using the macro menu
      2. Save the page and check the storage format of the page it should look like this
        <p><ac:emoticon ac:name="smile" /></p>
        
      1. Click on edit the page, don't add any thing and just save again
      2. Check the storage format one more ttime

      Expected Results

      Should be the same

      <p><ac:emoticon ac:name="smile" /></p>
      

      Actual Results

      It changes into an image

      <p>
        <img alt="(smile)" border="0" class="emoticon emoticon-smile" src="http://localhost:8090/s/en_GB/7109/b3b701b9e2252507726313c2d8313cd50ef12760/_/images/icons/emoticons/smile.png" title="(smile)"/>
      </p>
      

      In Confluence version 6.14.x, this bug changes the source URL from HTTPS to HTTP if Confluence is running behind proxy and SSL.

      Workaround

      1. Disable Collaborative Editing - To avoid the issue from occurring
      2. For Confluence 6.14.x, editing the storage format to point the broken URL from HTTP to HTTPS able to temporarily fix the issue.

       

      Notes

      1. This issue leads into a confusion when doing version comparison or when receiving email update about the change because Confluence is detecting an change about the content from macro to an image to it includes into the changes.
        In the screenshot attached you can see that Confluence is considering all emotions being part of the change, but actually only Start was changed to cool and normal to change.
      2. This is not reproducible with Confluence 5.10.x
      3. This could be an issue as emoticons are converted to hard links, and would present an issue when a type of base-URL related migration occurs in the future

       

      Atlassian update - 7 June 2019

      Hi everyone

      Thank you for your patience as we have been working on the solution for this issue. It has been a complicated one to solve and we wanted to include a few notes on this fix we have shipped in the 6.15.5 release.

      Adding new emoticons (including Hipchat emoticons) to a page: This is now fixed. They will be saved in valid storage format (e.g <ac:emoticon ac:name="smile"/> for standard Confluence emoticons or <ac:hipchat-emoticon ac:shortcut="name"/> for Hipchat emoticons).
      Existing pages with invalid emoticons and collaborative editing turned OFF: Viewing or editing the page will display fixed emoticons. Saving the page will correct the storage format of the broken emoticons.
      Existing pages with invalid emoticons and collaborative editing turned ON: Viewing the page will display fixed emoticons. If there is a current draft with broken emoticons, then the broken emoticons will be displayed once in the editor. On the next save of the page, any invalid emoticons will be fixed.

      For those using Hipchat emoticons, please note:

      If an invalid Hipchat emoticon has the same name as one of the standard Confluence emoticons (such as "smile", "thumbs-up" or "tick"), it will be converted into the corresponding Confluence emoticon once the page is saved.

      For all cases, saving the page will fix the broken emoticons. We explored the possibility of including a front-end editor fix to automatically resolve all of these broken emoticon instances. As it would involve checking every page and have an ongoing performance impact, we decided against doing this. So, if you come across any broken emoticons, please edit and update/publish your page to resolve the problem.

      Thanks again for your understanding.

      Niraj | Senior Development Team Lead, Confluence Server

        1. manage-apps-disable-hipchat-emoticons.png
          manage-apps-disable-hipchat-emoticons.png
          570 kB
        2. screenshot-1.png
          screenshot-1.png
          4 kB
        3. screenshot-2.png
          screenshot-2.png
          10 kB
        4. Screen Shot 2017-05-18 at 11.19.01.png
          Screen Shot 2017-05-18 at 11.19.01.png
          113 kB
        5. screenshot-3.png
          screenshot-3.png
          21 kB
        6. TableFilterAddOn-RedundantValuesInSelectList.png
          TableFilterAddOn-RedundantValuesInSelectList.png
          7 kB

            [CONFSERVER-52441] Emoticon is changing to image after the first save and edit of the page

            Dear customers,

            Noting your recent comments, I've looked through this ticket and tried to understand why you may be receiving this bug in your Log Analyzer results. This was showing up because our Log Analyzer matching pattern on this issue was set up to be slightly too liberal and has been pulling this bug in as a false positive. I've fixed the pattern so once your Log Analyser receives the new pattern update in the coming days this issue will no longer come up.

            Hope this helps, cheers.

             

            Michael Andreacchio

            Confluence DC Product Management

            Michael Andreacchio added a comment - Dear customers, Noting your recent comments, I've looked through this ticket and tried to understand why you may be receiving this bug in your Log Analyzer results. This was showing up because our Log Analyzer matching pattern on this issue was set up to be slightly too liberal and has been pulling this bug in as a false positive. I've fixed the pattern so once your Log Analyser receives the new pattern update in the coming days this issue will no longer come up. Hope this helps, cheers.   Michael Andreacchio Confluence DC Product Management

            Manuel added a comment -

            Same here. 7.13.7 and getting

            NFO Emoticon is changing to image after the first save and edit of the page 
              FIXED IN 6.15.5

            Manuel added a comment - Same here. 7.13.7 and getting NFO Emoticon is changing to image after the first save and edit of the page    FIXED IN 6.15.5

            Having this in the Log Analyzer with 1 recent occurence in LTS 7.13.7, too.

            Tilman Mayer added a comment - Having this in the Log Analyzer with 1 recent occurence in LTS 7.13.7, too.

            karenann added a comment -

            Same question as Steven Hawes. I just upgraded from 7.4.6 to 7.13.7 and this error appears in my post upgrade log analyzer.

            karenann added a comment - Same question as Steven Hawes. I just upgraded from 7.4.6 to 7.13.7 and this error appears in my post upgrade log analyzer.

            Hi! 

            Why would I still be getting this error pop up in my logs in 7.13.2?

            Steven Hawes added a comment - Hi!  Why would I still be getting this error pop up in my logs in 7.13.2?

            Quan Pham added a comment -

            A fix for this issue is available to Server and Data Center customers in Confluence 6.15.6
            Upgrade now or check out the Release Notes to see what other issues are resolved.

            Quan Pham added a comment - A fix for this issue is available to Server and Data Center customers in Confluence 6.15.6 Upgrade now or check out the Release Notes to see what other issues are resolved.

            Open Europa Wikis Team added a comment - - edited

            Hi,

            During this time if can help, I apply an another workaround (and keep collaborative mode enabled).

            You just need to rewrite your BASE_URL on the fly with mod_substitute (Apache):

            <Location "/">
             AddOutputFilterByType SUBSTITUTE text/html
             Substitute "s@http://BASE_URL/@https://BASE_URL/@i"
             </Location>

            Open Europa Wikis Team added a comment - - edited Hi, During this time if can help, I apply an another workaround (and keep collaborative mode enabled). You just need to rewrite your BASE_URL on the fly with mod_substitute (Apache): <Location "/" > AddOutputFilterByType SUBSTITUTE text/html Substitute "s@http: //BASE_URL/@https://BASE_URL/@i" </Location>

            We've had to withdraw 6.15.5, and will release 6.15.6 soon. We'll update this issue once the new version is available. You can find out more about the related issue here: CONFSERVER-58490

            Makisa Appleton added a comment - We've had to withdraw 6.15.5, and will release 6.15.6 soon. We'll update this issue once the new version is available. You can find out more about the related issue here: CONFSERVER-58490

            Alex K added a comment - - edited

            Dear customers, 

            To those who have upgraded to Confluence 6.15.5, there is a problem with the emoticons fix whereby standard emoticons with dashes in their name (e.g. "green-star" or "thumbs-up") will be incorrectly converted to an unknown HipChat emoticon. If you have upgraded to 6.15.5, please disable the "Confluence HipChat Emoticons Plugin" from "Manage Apps" screen in Confluence's administrator console. I have attached a screenshot showing how to do this, "Confluence HipChat Emoticons Plugin" is a bundled plugin, so please ensure that the "All Apps" option dropdown in the search dropdown is selected. Also, note that "Manage Apps" is accessible through "https://baseurl/plugins/servlet/upm/manage/all". 

            If you have not yet upgraded to Confluence 6.15.5, please hold off on doing so while we investigate this further. 

             

            Follow the resolution of this here: https://jira.atlassian.com/browse/CONFSERVER-58490

             

             

            Thank you to patrick.rohrberg2 for providing the information about this behaviour. 

            Alex K added a comment - - edited Dear customers,  To those who have upgraded to Confluence 6.15.5, there is a problem with the emoticons fix whereby standard emoticons with dashes in their name (e.g. "green-star" or "thumbs-up") will be incorrectly converted to an unknown HipChat emoticon. If you have upgraded to 6.15.5, please disable the "Confluence HipChat Emoticons Plugin" from "Manage Apps" screen in Confluence's administrator console. I have attached a screenshot showing how to do this, "Confluence HipChat Emoticons Plugin" is a bundled plugin, so please ensure that the "All Apps" option dropdown in the search dropdown is selected. Also, note that "Manage Apps" is accessible through "https://baseurl/plugins/servlet/upm/manage/all".  If you have not yet upgraded to Confluence 6.15.5, please hold off on doing so while we investigate this further.     Follow the resolution of this here:  https://jira.atlassian.com/browse/CONFSERVER-58490     Thank you to patrick.rohrberg2 for providing the information about this behaviour. 

            Patrick added a comment - - edited

            Hi Alex (why cant i use @ here?),

            since i dont have more "broken" pages in our test environment, i just restored the page.

            So, there are HipChat emoticons - you cant use them without hipchat integration. It will just shown as text, if you try to use it: (green)

            We dont have any HipChat integration and i really dont know how did i added this:

                  <p>
                    <ac:hipchat-emoticon ac:shortcut="green"/>
                  </p>
            

            HTML

            <span data-hipchat-emoticon="green" title="(green)" class="unknown-hipchat-emoticon">(green)</span>
            

            Please ignore my comment about "disapperad emotions" for now, i cant reproduce it..

            UPDATE
            Well - the "star" AND some other emotions are shown as Text like "(green) or "(blue)" after updating to 6.15.5 - it will be fixed if you go in edit mode.

            (If you view the HTML Code, you will see the "unknown-hipchat-emoticon" class.)

             

            UPDATE 2

            Thats crazy  The HipChat emoticons (non HipChat are stil fine) wont get fixed if you work on a restored revision.

            Maybe someone from Atlassian could explain this behaviour?

            Patrick added a comment - - edited Hi Alex (why cant i use @ here?), since i dont have more "broken" pages in our test environment, i just restored the page. So, there are HipChat emoticons - you cant use them without hipchat integration. It will just shown as text, if you try to use it: (green) We dont have any HipChat integration and i really dont know how did i added this: <p> <ac:hipchat-emoticon ac:shortcut= "green" /> </p> HTML <span data-hipchat-emoticon= "green" title= "(green)" class= "unknown-hipchat-emoticon" >(green)</span> Please ignore my comment about "disapperad emotions" for now, i cant reproduce it.. UPDATE Well - the "star" AND some other emotions are shown as Text like "(green) or "(blue)" after updating to 6.15.5 - it will be fixed if you go in edit mode. (If you view the HTML Code, you will see the "unknown-hipchat-emoticon" class.)   UPDATE 2 Thats crazy  The HipChat emoticons (non HipChat are stil fine) wont get fixed if you work on a restored revision. Maybe someone from Atlassian could explain this behaviour?

              oshen@atlassian.com Oliver Shen
              oraissi Omar Raissi (Inactive)
              Affected customers:
              145 This affects my team
              Watchers:
              163 Start watching this issue

                Created:
                Updated:
                Resolved: