Details
-
Suggestion
-
Resolution: Won't Do
-
None
Description
NOTE: This suggestion is for Confluence Server. Using Confluence Cloud? See the corresponding suggestion.
Hi
We had some trouble regarding compatibility with Confluence 5.7 and our Theme add-on Enterprise Theme [1].
The main reasons where UI related with your new feature Inline Commenting.
Because of a different DOM in our Theme and the fact that you are adding the right padding directly to the #content element (without using a css class ), the Theme looked ugly, because in our theme the inline style has to be at another place.
In the pre versions wasn't any event which we could listen on, so that we where not able to fix that layout issue. In the release version you added a set of new events, fired by Backbone, which gives us a chance to fix the layout - Thank you!
But events are sometimes lazy and inline styles aren't such a good way - so I just like to ask you, if it's possible to change this implementation in using a css class on the body like "has-inline-comments-panel" or something else, where the padding is connected to.
This will make the integration of the inline commenting more easy.
Thank you
Oliver Straesser
[1] https://marketplace.atlassian.com/plugins/net.getunik.confluence.skin.core
Attachments
Issue Links
- relates to
-
CONFCLOUD-36388 Inline comments integration issue with Enterprise Theme
- Closed