Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-36388

Inline comments integration issue with Enterprise Theme

    XMLWordPrintable

Details

    • We collect Confluence feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

    Description

      NOTE: This suggestion is for Confluence Server. Using Confluence Cloud? See the corresponding suggestion.

      Hi

      We had some trouble regarding compatibility with Confluence 5.7 and our Theme add-on Enterprise Theme [1].

      The main reasons where UI related with your new feature Inline Commenting.
      Because of a different DOM in our Theme and the fact that you are adding the right padding directly to the #content element (without using a css class ), the Theme looked ugly, because in our theme the inline style has to be at another place.

      In the pre versions wasn't any event which we could listen on, so that we where not able to fix that layout issue. In the release version you added a set of new events, fired by Backbone, which gives us a chance to fix the layout - Thank you!

      But events are sometimes lazy and inline styles aren't such a good way - so I just like to ask you, if it's possible to change this implementation in using a css class on the body like "has-inline-comments-panel" or something else, where the padding is connected to.

      This will make the integration of the inline commenting more easy.

      Thank you
      Oliver Straesser

      [1] https://marketplace.atlassian.com/plugins/net.getunik.confluence.skin.core

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              95cffe71a7e5 Oliver Straesser
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: