Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-3535

userlister macro plugin code supplied by Scott Frederick needs to be reviewed and incorporated into 1.4.x codebase.

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 2.0
    • None
    • We collect Confluence feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      I have done some work on the userlister macro plugin that I want to contribute back to you. The source code for the changes is in the attached .zip file. Here is a summary of the changes:

      1). The "online" parameter was not working at all. This was due to a couple of problems:

      UserListener.handleEvent was calling UserList.userLoggedIn() on both the LoginEvent and the LogoutEvent (UserList.userLoggedOut() was never getting called), so once someone logged in they would always be listed as logged in.

      UserList.matchEligibleUsers was not working as intended. Elements were being removed from the same list that was being iterated through, yielding unpredictable results in the resulting list.

      2). I wanted to be able to see visually all users' logged in state. I enhanced userlister to show one of two icons beside the user name, depending on whether they are logged in or not.

      Let me know if you have any questions or if I forgot to send you something.

      Scott Frederick
      Airline Products Development
      Sabre Airline Solutions
      682-605-4666

        1. userlister.sabre.zip
          14 kB
          Daniel Ostermeier

              8873c89cc788 Daniel Ostermeier
              8873c89cc788 Daniel Ostermeier
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: