-
Bug
-
Resolution: Fixed
-
Medium
-
5.5.4
The PageIncludeMacro can fail with a NullPointerException. Here's an example stack trace:
2014-07-30 22:10:19,521 ERROR [catalina-exec-32] [xhtml.view.macro.ViewMacroMarshaller] marshalInternal Error rendering macro: include -- url: /display/DOC/Exporting+Confluence+Pages+and+Spaces+to+PDF | page: 139527 | userName: anonymous | referer: https://www.google.com/ | action: viewpage java.lang.NullPointerException at com.atlassian.confluence.plugins.macros.advanced.DefaultPageProvider.resolve(DefaultPageProvider.java:48) at com.atlassian.confluence.plugins.macros.advanced.PageIncludeMacro.execute(PageIncludeMacro.java:97) at sun.reflect.GeneratedMethodAccessor830.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.atlassian.confluence.macro.xhtml.XhtmlMacroManager$ResourceAwareMacroInvocationHandler.invoke(XhtmlMacroManager.java:225) at com.sun.proxy.$Proxy2247.execute(Unknown Source) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshalInternal(ViewMacroMarshaller.java:113) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshal(ViewMacroMarshaller.java:68) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshal(ViewMacroMarshaller.java:30) at com.atlassian.confluence.content.render.xhtml.UnmarshalMarshalFragmentTransformer.transform(UnmarshalMarshalFragmentTransformer.java:31) at com.atlassian.confluence.content.render.xhtml.transformers.DefaultFragmentTransformer.transformFragment(DefaultFragmentTransformer.java:153) at com.atlassian.confluence.content.render.xhtml.transformers.DefaultFragmentTransformer.transform(DefaultFragmentTransformer.java:129) at com.atlassian.confluence.content.render.xhtml.storage.StorageXhtmlTransformer.transform(StorageXhtmlTransformer.java:44) at com.atlassian.confluence.content.render.xhtml.TransformerChain.transform(TransformerChain.java:41) at com.atlassian.confluence.content.render.xhtml.PluggableTransformerChain.transform(PluggableTransformerChain.java:51) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:80) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:68) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:58) at com.atlassian.confluence.content.render.xhtml.DeviceTypeAwareRenderer.render(DeviceTypeAwareRenderer.java:42) at com.atlassian.confluence.pages.actions.ViewPageAction.getXHtmlComments(ViewPageAction.java:299)
The NPE comes about from a null link parameter. The code needs to account for that properly.
Updated by ple
The log above is for rendering comments and the log below is for rendering page
2014-07-31 00:49:26,521 ERROR [catalina-exec-32] [xhtml.view.macro.ViewMacroMarshaller] marshalInternal Error rendering macro: include -- url: /display/CONFKB/Does+Confluence+Support+DIGEST+MD5/ | page: 229180140 | userName: anonymous | action: viewpage java.lang.NullPointerException at com.atlassian.confluence.plugins.macros.advanced.DefaultPageProvider.resolve(DefaultPageProvider.java:48) at com.atlassian.confluence.plugins.macros.advanced.PageIncludeMacro.execute(PageIncludeMacro.java:97) at sun.reflect.GeneratedMethodAccessor830.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.atlassian.confluence.macro.xhtml.XhtmlMacroManager$ResourceAwareMacroInvocationHandler.invoke(XhtmlMacroManager.java:225) at com.sun.proxy.$Proxy2247.execute(Unknown Source) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshalInternal(ViewMacroMarshaller.java:113) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshal(ViewMacroMarshaller.java:68) at com.atlassian.confluence.content.render.xhtml.view.macro.ViewMacroMarshaller.marshal(ViewMacroMarshaller.java:30) at com.atlassian.confluence.content.render.xhtml.UnmarshalMarshalFragmentTransformer.transform(UnmarshalMarshalFragmentTransformer.java:31) at com.atlassian.confluence.content.render.xhtml.transformers.DefaultFragmentTransformer.transformFragment(DefaultFragmentTransformer.java:153) at com.atlassian.confluence.content.render.xhtml.transformers.DefaultFragmentTransformer.transform(DefaultFragmentTransformer.java:129) at com.atlassian.confluence.content.render.xhtml.storage.StorageXhtmlTransformer.transform(StorageXhtmlTransformer.java:44) at com.atlassian.confluence.content.render.xhtml.TransformerChain.transform(TransformerChain.java:41) at com.atlassian.confluence.content.render.xhtml.PluggableTransformerChain.transform(PluggableTransformerChain.java:51) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:80) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:68) at com.atlassian.confluence.content.render.xhtml.DefaultRenderer.render(DefaultRenderer.java:58) at com.atlassian.confluence.content.render.xhtml.DeviceTypeAwareRenderer.render(DeviceTypeAwareRenderer.java:42) at com.atlassian.confluence.pages.actions.ViewPageAction.execute(ViewPageAction.java:261)
![[Extranet] Page](/images/icons/generic_link_16.png "[Extranet] Page"){kind=icon}
[CONFSERVER-34442] Page Include Macro generates NPE
I have verified this fixed. It works fine on Confluence 5.3, 5.5.0 and 5.6 and Cluster Confluence 5.5-m22
This is verify steps:
- Make sure the version of advanced macro is 3.4.1 or lower
- Create a sub page with page title is "_sub page" in DS space (default space)
- Create a new space (ex. TEST) and a new page that named "top page".
- Include sub page to this top page (using include macro)
- Install Confluence-source-editor macro
- Edit the top page by using source editor then paste the old content (below) to this page then save it
<p><ac:structured-macro ac:name="include"> <ac:parameter ac:name="pageTitle">_sub page</ac:parameter> <ac:parameter ac:name="spaceKey">DS</ac:parameter></ac:structured-macro></p>
- => It shows an error message on the top page
- Upgrade new advanced macro version (the fixed version is 3.4.2)
- Go to the top page => it works fine.
Notes
Do you know whether every page include macro generates a NPE? Or only certain pages?
We have the same issue on multiple pages using Conf 5.5.6.
Can we just upgrade the advanced macros plugin to a newer version by replacing the jar and keep Conf 5.5.6?
I would prefer this way since upgrading a huge instance takes much more time than just replacing a jar.