Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-27746

The "Learn more about templates" link is hard coded and wrong. Change to use help-paths.properties. Check for others.

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 4.3.3
    • None
    • None
    • master (updated ~12PM 2012.07.17)

      NOTE: This bug report is for Confluence Server. Using Confluence Cloud? See the corresponding bug report.

      Clicking on this link takes the user to a disambiguation page on CAC. It is not obvious which link they should click.

      We need to point to the page with Sarah's latest updates

          Form Name

            [CONFSERVER-27746] The "Learn more about templates" link is hard coded and wrong. Change to use help-paths.properties. Check for others.

            Confirmed links are correct on a pull on my laptop.

            Petch (Inactive) added a comment - Confirmed links are correct on a pull on my laptop.

            Minor changes. Committed to stable.

            Petch (Inactive) added a comment - Minor changes. Committed to stable.

            Petch (Inactive) added a comment - - edited

            Only other occurrence (that was not in setup) was the following:

            gadget.directory.help.more.info=(See our <a href="http://confluence.atlassian.com/display/DOC/Configuring+Confluence+Gadgets+for+Use+in+Other+Applications" target="_blank">documentation</a> for more information).

            Found via Browse > Confluence Gadgets.

            Petch (Inactive) added a comment - - edited Only other occurrence (that was not in setup) was the following: gadget.directory.help.more.info=(See our <a href="http://confluence.atlassian.com/display/DOC/Configuring+Confluence+Gadgets+for+Use+in+Other+Applications" target="_blank">documentation</a> for more information). Found via Browse > Confluence Gadgets.

            This would be broken in previous releases too, so we should probably fix this for 4.2 aswell.

            Petch (Inactive) added a comment - This would be broken in previous releases too, so we should probably fix this for 4.2 aswell.

            Petch (Inactive) added a comment - - edited

            It is indeed hardcoded (I wasn't expecting it to be - I just thought the help path was wrong):

            confluence-plugins/confluence-bundled-plugins/confluence-dashboard-actions/src/main/resources/com/atlassian/confluence/plugins/dashboard/i18n.properties

            dashboard.create.template.description=Learn more about <a href="http://confluence.atlassian.com/display/DOC/Working+with+Templates+Overview" target="_blank">templates</a>

            Petch (Inactive) added a comment - - edited It is indeed hardcoded (I wasn't expecting it to be - I just thought the help path was wrong): confluence-plugins/confluence-bundled-plugins/confluence-dashboard-actions/src/main/resources/com/atlassian/confluence/plugins/dashboard/i18n.properties dashboard.create.template.description=Learn more about <a href="http://confluence.atlassian.com/display/DOC/Working+with+Templates+Overview" target="_blank">templates</a>

            Matt Ryall added a comment -

            Whoever picks this up, could you please have a quick scan through the source for any other similar non-"doc-link" links, and fix them to use the same mechanism?

            Outside of the setup wizard, there should be nothing hard-coded to include "http://confluence.atlassian.com" or "https://confluence.atlassian.com" except for the single line in help-paths.properties which sets the default doc location.

            Matt Ryall added a comment - Whoever picks this up, could you please have a quick scan through the source for any other similar non-"doc-link" links, and fix them to use the same mechanism? Outside of the setup wizard, there should be nothing hard-coded to include "http://confluence.atlassian.com" or "https://confluence.atlassian.com" except for the single line in help-paths.properties which sets the default doc location.

            SarahA added a comment -

            Hallo Craig

            The link should use the help-paths.properties file (i.e. not be hard-coded to CAC or the DOC space). In that file, the "value" part of the key-value pair should be:
            Working+with+Templates

            Thus, when coming from Confluence 4.3, it will for a very short period of time point to this page
            https://confluence.atlassian.com/display/DOC/Working+with+Templates

            See CONFDEV-9665

            matt@atlassian.com – this is the issue I mentioned at our meeting yesterday. This type of hard-coded link breaks our help system in 3 ways:

            • Version control
            • Behind-the-firewall docs for customers
            • Tech writers cannot see that the app references the help link (not in help-paths.properties) so we feel free to change the page name.

            SarahA added a comment - Hallo Craig The link should use the help-paths.properties file (i.e. not be hard-coded to CAC or the DOC space). In that file, the "value" part of the key-value pair should be: Working+with+Templates Thus, when coming from Confluence 4.3, it will for a very short period of time point to this page https://confluence.atlassian.com/display/DOC/Working+with+Templates See CONFDEV-9665 matt@atlassian.com – this is the issue I mentioned at our meeting yesterday. This type of hard-coded link breaks our help system in 3 ways: Version control Behind-the-firewall docs for customers Tech writers cannot see that the app references the help link (not in help-paths.properties) so we feel free to change the page name.

            smaddox do you know where the link about should go to now? (It's currently https://confluence.atlassian.com/display/DOC/Working+with+Templates+Overview).

            Petch (Inactive) added a comment - smaddox do you know where the link about should go to now? (It's currently https://confluence.atlassian.com/display/DOC/Working+with+Templates+Overview ).

              cpetchell Petch (Inactive)
              jcorea JoeyA
              Affected customers:
              0 This affects my team
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: